Skip to content

Commit 420b852

Browse files
committed
Fix unit test
1 parent 1e51590 commit 420b852

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

modules/indexer/issues/internal/model.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ type IndexerData struct {
3030
LabelIDs []int64 `json:"label_ids"`
3131
NoLabel bool `json:"no_label"` // True if LabelIDs is empty
3232
MilestoneID int64 `json:"milestone_id"`
33-
ProjectIDs []int64 `json:"project_ids"`
33+
ProjectIDs []int64 `json:"project_id"`
3434
ProjectColumnID int64 `json:"project_board_id"` // the key should be kept as project_board_id to keep compatible
3535
PosterID int64 `json:"poster_id"`
3636
AssigneeID int64 `json:"assignee_id"`

modules/indexer/issues/internal/tests/tests.go

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,7 @@ var cases = []*testIndexerCase{
312312
Expected: func(t *testing.T, data map[int64]*internal.IndexerData, result *internal.SearchResult) {
313313
assert.Len(t, result.Hits, 5)
314314
for _, v := range result.Hits {
315-
if len(data[v.ID].ProjectIDs) > 0 {
316-
assert.Equal(t, int64(1), data[v.ID].ProjectIDs[0])
317-
}
315+
assert.Contains(t, data[v.ID].ProjectIDs, int64(1))
318316
}
319317
assert.Equal(t, countIndexerData(data, func(v *internal.IndexerData) bool {
320318
if len(data[v.ID].ProjectIDs) > 0 {
@@ -333,18 +331,12 @@ var cases = []*testIndexerCase{
333331
ProjectIDs: []int64{0},
334332
},
335333
Expected: func(t *testing.T, data map[int64]*internal.IndexerData, result *internal.SearchResult) {
336-
assert.Len(t, result.Hits, 5)
334+
assert.Len(t, result.Hits, 0)
337335
for _, v := range result.Hits {
338336
if len(data[v.ID].ProjectIDs) > 0 {
339-
assert.Equal(t, int64(0), data[v.ID].ProjectIDs[0])
337+
assert.Equal(t, int64(1), data[v.ID].ProjectIDs[0])
340338
}
341339
}
342-
assert.Equal(t, countIndexerData(data, func(v *internal.IndexerData) bool {
343-
if len(data[v.ID].ProjectIDs) > 0 {
344-
return v.ProjectIDs[0] == 1
345-
}
346-
return false
347-
}), result.Total)
348340
},
349341
},
350342
{
@@ -717,6 +709,10 @@ func generateDefaultIndexerData() []*internal.IndexerData {
717709
for i := range subscriberIDs {
718710
subscriberIDs[i] = int64(i) + 1 // SubscriberID should not be 0
719711
}
712+
projectIDs := make([]int64, id%5)
713+
for i := range projectIDs {
714+
projectIDs[i] = int64(i) + 1 // projectID should not be 0
715+
}
720716

721717
data = append(data, &internal.IndexerData{
722718
ID: id,
@@ -730,7 +726,7 @@ func generateDefaultIndexerData() []*internal.IndexerData {
730726
LabelIDs: labelIDs,
731727
NoLabel: len(labelIDs) == 0,
732728
MilestoneID: issueIndex % 4,
733-
ProjectIDs: []int64{issueIndex % 5},
729+
ProjectIDs: projectIDs,
734730
ProjectColumnID: issueIndex % 6,
735731
PosterID: id%10 + 1, // PosterID should not be 0
736732
AssigneeID: issueIndex % 10,

0 commit comments

Comments
 (0)