add comment

wxiaoguang · wxiaoguang · commit 42d032de8870 · 2024-12-12T12:11:56.000+08:00
diff --git a/routers/api/v1/repo/pull.go b/routers/api/v1/repo/pull.go
@@ -1180,7 +1180,8 @@ func parseCompareInfo(ctx *context.APIContext, form api.CreatePullRequestOption)
 		return nil, nil
 	}
 
-	// user should have permission to read headrepo's codes
+	// user should have permission to read headRepo's codes
+	// TODO: could the logic be simplified if the headRepo is the same as the baseRepo? Need to think more about it.
 	permHead, err := access_model.GetUserRepoPermission(ctx, headRepo, ctx.Doer)
 	if err != nil {
 		ctx.Error(http.StatusInternalServerError, "GetUserRepoPermission", err)

Original file line number	Diff line number	Diff line change
`@@ -1180,7 +1180,8 @@ func parseCompareInfo(ctx *context.APIContext, form api.CreatePullRequestOption)`
`1180`	`1180`	`return nil, nil`
`1181`	`1181`	`}`
`1182`	`1182`
`1183`		`- // user should have permission to read headrepo's codes`
	`1183`	`+ // user should have permission to read headRepo's codes`
	`1184`	`+ // TODO: could the logic be simplified if the headRepo is the same as the baseRepo? Need to think more about it.`
`1184`	`1185`	`permHead, err := access_model.GetUserRepoPermission(ctx, headRepo, ctx.Doer)`
`1185`	`1186`	`if err != nil {`
`1186`	`1187`	`ctx.Error(http.StatusInternalServerError, "GetUserRepoPermission", err)`