Add todo for checking permissions

lunny · lunny · commit 43aeacb1abc4 · 2024-11-25T21:48:51.000-08:00
diff --git a/routers/web/repo/pull_review.go b/routers/web/repo/pull_review.go
@@ -398,6 +398,7 @@ func UpdatePullReviewRequest(ctx *context.Context) {
 				return
 			}
 
+			// TODO: Team review request should check if the team has permission to review the PR
 			_, err = pull_service.TeamReviewRequest(ctx, issue.PullRequest, ctx.Doer, team, action == "attach")
 			if err != nil {
 				if issues_model.IsErrNotValidReviewRequest(err) {
@@ -430,6 +431,7 @@ func UpdatePullReviewRequest(ctx *context.Context) {
 			return
 		}
 
+		// TODO: Reviewer review request should check if the user has permission to review the PR
 		_, err = pull_service.ReviewRequest(ctx, issue.PullRequest, ctx.Doer, &ctx.Repo.Permission, reviewer, action == "attach")
 		if err != nil {
 			if issues_model.IsErrNotValidReviewRequest(err) {

Original file line number	Diff line number	Diff line change
`@@ -398,6 +398,7 @@ func UpdatePullReviewRequest(ctx *context.Context) {`
`398`	`398`	`return`
`399`	`399`	`}`
`400`	`400`
	`401`	`+ // TODO: Team review request should check if the team has permission to review the PR`
`401`	`402`	`_, err = pull_service.TeamReviewRequest(ctx, issue.PullRequest, ctx.Doer, team, action == "attach")`
`402`	`403`	`if err != nil {`
`403`	`404`	`if issues_model.IsErrNotValidReviewRequest(err) {`
`@@ -430,6 +431,7 @@ func UpdatePullReviewRequest(ctx *context.Context) {`
`430`	`431`	`return`
`431`	`432`	`}`
`432`	`433`
	`434`	`+ // TODO: Reviewer review request should check if the user has permission to review the PR`
`433`	`435`	`_, err = pull_service.ReviewRequest(ctx, issue.PullRequest, ctx.Doer, &ctx.Repo.Permission, reviewer, action == "attach")`
`434`	`436`	`if err != nil {`
`435`	`437`	`if issues_model.IsErrNotValidReviewRequest(err) {`