add UI for editing secrets

Author: techknowlogick

routers/web/repo/setting/secrets.go

@@ -114,6 +114,26 @@ func SecretsPost(ctx *context.Context) {
 	)
 }
 
+func SecretsEdit(ctx *context.Context) {
+	sCtx, err := getSecretsCtx(ctx)
+	if err != nil {
+		ctx.ServerError("getSecretsCtx", err)
+		return
+	}
+
+	if ctx.HasError() {
+		ctx.JSONError(ctx.GetErrMsg())
+		return
+	}
+
+	shared.PerformSecretsEdit(
+		ctx,
+		sCtx.OwnerID,
+		sCtx.RepoID,
+		sCtx.RedirectLink,
+	)
+}
+
 func SecretsDelete(ctx *context.Context) {
 	sCtx, err := getSecretsCtx(ctx)
 	if err != nil {

routers/web/shared/secrets/secrets.go

@@ -4,6 +4,8 @@
 package secrets
 
 import (
+	"fmt"
+
 	"code.gitea.io/gitea/models/db"
 	secret_model "code.gitea.io/gitea/models/secret"
 	"code.gitea.io/gitea/modules/log"
@@ -38,6 +40,37 @@ func PerformSecretsPost(ctx *context.Context, ownerID, repoID int64, redirectURL
 	ctx.JSONRedirect(redirectURL)
 }
 
+func PerformSecretsEdit(ctx *context.Context, ownerID, repoID int64, redirectURL string) {
+	form := web.GetForm(ctx).(*forms.EditSecretForm)
+	id := ctx.PathParamInt64("secret_id")
+
+	if id == 0 {
+		ctx.ServerError("PerformSecretsEdit", fmt.Errorf("id not found"))
+		return
+	}
+
+	secrets, err := db.Find[secret_model.Secret](ctx, secret_model.FindSecretsOptions{OwnerID: ownerID, RepoID: repoID, SecretID: id})
+	if err != nil {
+		ctx.ServerError("FindSecrets", err)
+		return
+	}
+
+	if len(secrets) != 1 {
+		ctx.ServerError("FindSecrets", fmt.Errorf("secret not found"))
+		return
+	}
+
+	s, _, err := secret_service.CreateOrUpdateSecret(ctx, ownerID, repoID, secrets[0].Name, util.ReserveLineBreakForTextarea(form.Data))
+	if err != nil {
+		log.Error("CreateOrUpdateSecret failed: %v", err)
+		ctx.JSONError(ctx.Tr("secrets.edit.failed"))
+		return
+	}
+
+	ctx.Flash.Success(ctx.Tr("secrets.edit.success", s.Name))
+	ctx.JSONRedirect(redirectURL)
+}
+
 func PerformSecretsDelete(ctx *context.Context, ownerID, repoID int64, redirectURL string) {
 	id := ctx.FormInt64("id")
 

routers/web/web.go

@@ -446,6 +446,7 @@ func registerRoutes(m *web.Router) {
 		m.Group("/secrets", func() {
 			m.Get("", repo_setting.Secrets)
 			m.Post("", web.Bind(forms.AddSecretForm{}), repo_setting.SecretsPost)
+			m.Post("/{secret_id}/edit", web.Bind(forms.EditSecretForm{}), repo_setting.SecretsEdit)
 			m.Post("/delete", repo_setting.SecretsDelete)
 		})
 	}

services/forms/user_form.go

@@ -335,6 +335,17 @@ func (f *AddSecretForm) Validate(req *http.Request, errs binding.Errors) binding
 	return middleware.Validate(errs, ctx.Data, f, ctx.Locale)
 }
 
+// AddSecretForm for adding secrets
+type EditSecretForm struct {
+	Data string `binding:"Required;MaxSize(65535)"`
+}
+
+// Validate validates the fields
+func (f *EditSecretForm) Validate(req *http.Request, errs binding.Errors) binding.Errors {
+	ctx := context.GetValidateContext(req)
+	return middleware.Validate(errs, ctx.Data, f, ctx.Locale)
+}
+
 type EditVariableForm struct {
 	Name string `binding:"Required;MaxSize(255)"`
 	Data string `binding:"Required;MaxSize(65535)"`

templates/shared/secrets/add_list.tmpl

@@ -30,6 +30,15 @@
 				<span class="color-text-light-2">
 					{{ctx.Locale.Tr "settings.added_on" (DateTime "short" .CreatedUnix)}}
 				</span>
+				<button class="ui btn interact-bg tw-p-2 show-modal"
+					data-modal="#edit-secret-modal"
+					data-modal-form.action="{{$.Link}}/{{.ID}}/edit"
+					data-modal-header="{{ctx.Locale.Tr "secrets.edit"}}"
+					data-modal-secret-name="{{.Name}}"
+					data-tooltip-content="{{ctx.Locale.Tr "secrets.edit"}}"
+				>
+					{{svg "octicon-pencil"}}
+				</button>
 				<button class="ui btn interact-bg link-action tw-p-2"
 					data-url="{{$.Link}}/delete?id={{.ID}}"
 					data-modal-confirm="{{ctx.Locale.Tr "secrets.deletion.description"}}"
@@ -60,8 +69,42 @@
 			<div class="field">
 				<label for="secret-name">{{ctx.Locale.Tr "name"}}</label>
 				<input autofocus required
+					name="name"
 					id="secret-name"
+					value="{{.name}}"
+					pattern="^(?!GITEA_|GITHUB_)[a-zA-Z_][a-zA-Z0-9_]*$"
+					placeholder="{{ctx.Locale.Tr "secrets.creation.name_placeholder"}}"
+				>
+			</div>
+			<div class="field">
+				<label for="secret-data">{{ctx.Locale.Tr "value"}}</label>
+				<textarea required
+					id="secret-data"
+					name="data"
+					placeholder="{{ctx.Locale.Tr "secrets.creation.value_placeholder"}}"
+				></textarea>
+			</div>
+		</div>
+		{{template "base/modal_actions_confirm" (dict "ModalButtonTypes" "confirm")}}
+	</form>
+</div>
+
+{{/* Edit secret dialog */}}
+<div class="ui small modal" id="edit-secret-modal">
+	<div class="header">
+		<span id="actions-modal-header"></span>
+	</div>
+	<form class="ui form form-fetch-action" method="post">
+		<div class="content">
+			{{.CsrfTokenHtml}}
+			<div class="field">
+				{{ctx.Locale.Tr "secrets.description"}}
+			</div>
+			<div class="field">
+				<label for="secret-name">{{ctx.Locale.Tr "name"}}</label>
+				<input disabled
 					name="name"
+					id="secret-name"
 					value="{{.name}}"
 					pattern="^(?!GITEA_|GITHUB_)[a-zA-Z_][a-zA-Z0-9_]*$"
 					placeholder="{{ctx.Locale.Tr "secrets.creation.name_placeholder"}}"