Fix bug when updating actions numbers

Author: lunny

models/asymkey/gpg_key_verify.go

@@ -78,7 +78,7 @@ func VerifyGPGKey(ctx context.Context, ownerID int64, keyID, token, signature st
 		}
 
 		key.Verified = true
-		if _, err := db.GetEngine(ctx).ID(key.ID).SetExpr("verified", true).Update(new(GPGKey)); err != nil {
+		if _, err := db.GetEngine(ctx).ID(key.ID).Cols("verified").Update(key); err != nil {
 			return "", err
 		}
 

models/issues/label.go

@@ -495,19 +495,23 @@ func CountLabelsByOrgID(ctx context.Context, orgID int64) (int64, error) {
 }
 
 func updateLabelCols(ctx context.Context, l *Label, cols ...string) error {
-	_, err := db.GetEngine(ctx).ID(l.ID).
-		SetExpr("num_issues",
+	sess := db.GetEngine(ctx).ID(l.ID)
+	if slices.Contains(cols, "num_issues") {
+		sess.SetExpr("num_issues",
 			builder.Select("count(*)").From("issue_label").
 				Where(builder.Eq{"label_id": l.ID}),
-		).
-		SetExpr("num_closed_issues",
+		)
+	}
+	if slices.Contains(cols, "num_closed_issues") {
+		sess.SetExpr("num_closed_issues",
 			builder.Select("count(*)").From("issue_label").
 				InnerJoin("issue", "issue_label.issue_id = issue.id").
 				Where(builder.Eq{
 					"issue_label.label_id": l.ID,
 					"issue.is_closed":      true,
 				}),
-		).
-		Cols(cols...).Update(l)
+		)
+	}
+	_, err := sess.Cols(cols...).Update(l)
 	return err
 }

models/issues/milestone.go

@@ -181,6 +181,7 @@ func updateMilestone(ctx context.Context, m *Milestone) error {
 func UpdateMilestoneCounters(ctx context.Context, id int64) error {
 	e := db.GetEngine(ctx)
 	_, err := e.ID(id).
+		Cols("num_issues", "num_closed_issues").
 		SetExpr("num_issues", builder.Select("count(*)").From("issue").Where(
 			builder.Eq{"milestone_id": id},
 		)).

models/migrations/v1_18/v229.go

@@ -21,6 +21,7 @@ func UpdateOpenMilestoneCounts(x *xorm.Engine) error {
 
 	for _, id := range openMilestoneIDs {
 		_, err := x.ID(id).
+			Cols("num_issues", "num_closed_issues").
 			SetExpr("num_issues", builder.Select("count(*)").From("issue").Where(
 				builder.Eq{"milestone_id": id},
 			)).

models/repo/topic.go

@@ -159,7 +159,7 @@ func RemoveTopicsFromRepo(ctx context.Context, repoID int64) error {
 		builder.In("id",
 			builder.Select("topic_id").From("repo_topic").Where(builder.Eq{"repo_id": repoID}),
 		),
-	).Cols("repo_count").SetExpr("repo_count", "repo_count-1").Update(&Topic{})
+	).Decr("repo_count").Update(&Topic{})
 	if err != nil {
 		return err
 	}