fix

wxiaoguang · wxiaoguang · commit 47a6bbded1c5 · 2025-09-25T10:21:40.000+08:00
diff --git a/services/pull/update.go b/services/pull/update.go
@@ -39,7 +39,8 @@ func Update(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.
 		return fmt.Errorf("unable to load BaseRepo for PR[%d] during update-by-merge: %w", pr.ID, err)
 	}
 
-	if pr.ID > 0 { // only a real PR needs to check this FIXME: why it needs this check?
+	// TODO: FakePR: if the PR is a fake PR (for example: from Merge Upstream), then no need to check diverging
+	if pr.ID > 0 {
 		diffCount, err := GetDiverging(ctx, pr)
 		if err != nil {
 			return err

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,8 @@ func Update(ctx context.Context, pr issues_model.PullRequest, doer user_model.`
`39`	`39`	`return fmt.Errorf("unable to load BaseRepo for PR[%d] during update-by-merge: %w", pr.ID, err)`
`40`	`40`	`}`
`41`	`41`
`42`		`- if pr.ID > 0 { // only a real PR needs to check this FIXME: why it needs this check?`
	`42`	`+ // TODO: FakePR: if the PR is a fake PR (for example: from Merge Upstream), then no need to check diverging`
	`43`	`+ if pr.ID > 0 {`
`43`	`44`	`diffCount, err := GetDiverging(ctx, pr)`
`44`	`45`	`if err != nil {`
`45`	`46`	`return err`