Fix bug

Author: lunny

modules/gitrepo/http.go

@@ -14,10 +14,10 @@ import (
 
 func serviceCmd(service string) *git.Command {
 	switch service {
-	case "git-receive-pack":
-		return git.NewCommand("git-receive-pack")
-	case "git-upload-pack":
-		return git.NewCommand("git-upload-pack")
+	case "receive-pack":
+		return git.NewCommand("receive-pack")
+	case "upload-pack":
+		return git.NewCommand("upload-pack")
 	default:
 		// the service should be checked before invoking this function
 		panic("unknown service: " + service)

routers/web/repo/githttp.go

@@ -377,14 +377,20 @@ func (h *serviceHandler) sendFile(ctx *context.Context, contentType, file string
 	fs := gitrepo.GetRepoFS(h.getStorageRepo())
 	f, err := fs.Open(file)
 	if err != nil {
-		log.Error("Failed to open file: %v", err)
+		if os.IsNotExist(err) {
+			ctx.Resp.WriteHeader(http.StatusNotFound)
+		} else {
+			log.Error("Unable to open file %s: %v", file, err)
+			ctx.Resp.WriteHeader(http.StatusInternalServerError)
+		}
 		return
 	}
-	defer f.Close()
 
 	fi, err := f.Stat()
-	if os.IsNotExist(err) {
-		ctx.Resp.WriteHeader(http.StatusNotFound)
+	f.Close()
+	if err != nil {
+		log.Error("Unable to stat file %s: %v", file, err)
+		ctx.Resp.WriteHeader(http.StatusInternalServerError)
 		return
 	}