improve

Author: yp05327

routers/api/v1/repo/issue_label.go

@@ -109,11 +109,6 @@ func AddIssueLabels(ctx *context.APIContext) {
 		return
 	}
 
-	// if permission is denied, the prepareForReplaceOrAdd function will return nil, nil, nil
-	if ctx.Written() {
-		return
-	}
-
 	if err = issue_service.AddLabels(ctx, issue, ctx.Doer, labels); err != nil {
 		ctx.Error(http.StatusInternalServerError, "AddLabels", err)
 		return
@@ -244,10 +239,6 @@ func ReplaceIssueLabels(ctx *context.APIContext) {
 		return
 	}
 
-	if ctx.Written() {
-		return
-	}
-
 	if err := issue_service.ReplaceLabels(ctx, issue, ctx.Doer, labels); err != nil {
 		ctx.Error(http.StatusInternalServerError, "ReplaceLabels", err)
 		return
@@ -361,7 +352,7 @@ func prepareForReplaceOrAdd(ctx *context.APIContext, form api.IssueLabelsOption)
 
 	if !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) {
 		ctx.Status(http.StatusForbidden)
-		return nil, nil, nil
+		return nil, nil, fmt.Errorf("permission denied")
 	}
 
 	return issue, labels, err