Fix wrong redirect URL after fork, add test

Author: brechtvl

routers/web/repo/editor.go

@@ -178,7 +178,7 @@ func GetEditRepositoryOrFork(ctx *context.Context, editOperation string) *repo_m
 	}
 
 	// No editable repository, suggest to create a fork
-	forkToEditFileCommon(ctx, ctx.Repo.TreePath, editOperation, notEditableMessage)
+	forkToEditFileCommon(ctx, editOperation, ctx.Repo.TreePath, notEditableMessage)
 	ctx.HTML(http.StatusOK, tplForkFile)
 	return nil
 }
@@ -299,7 +299,7 @@ func ForkToEditFilePost(ctx *context.Context) {
 			SingleBranch: ctx.Repo.BranchName,
 		}, tplForkFile, form)
 		if err != nil {
-			forkToEditFileCommon(ctx, form.TreePath, form.EditOperation, notEditableMessage)
+			forkToEditFileCommon(ctx, form.EditOperation, form.TreePath, notEditableMessage)
 			ctx.HTML(http.StatusOK, tplForkFile)
 			return
 		}

tests/integration/editor_test.go

@@ -20,6 +20,7 @@ import (
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/json"
+	"code.gitea.io/gitea/modules/test"
 	"code.gitea.io/gitea/modules/translation"
 	"code.gitea.io/gitea/tests"
 
@@ -477,7 +478,8 @@ func forkToEdit(t *testing.T, session *TestSession, owner, repo, operation, bran
 			"edit_operation": operation,
 		},
 	)
-	session.MakeRequest(t, req, http.StatusSeeOther)
+	resp = session.MakeRequest(t, req, http.StatusSeeOther)
+	assert.Equal(t, "/"+path.Join(owner, repo, operation, branch, filePath), test.RedirectURL(resp))
 }
 
 func testForkToEdit(t *testing.T, session *TestSession, user, owner, repo, branch, filePath string) {