Add some comments

lunny · lunny · commit 4eff10f8d1d8 · 2025-01-02T18:18:22.000-08:00
diff --git a/routers/private/hook_post_receive.go b/routers/private/hook_post_receive.go
@@ -357,6 +357,8 @@ func handlePullRequestMerging(ctx *gitea_context.PrivateContext, opts *private.H
 		return
 	}
 
+	// FIXME: Maybe we need a `PullRequestStatusMerged` status for PRs that are merged, currently we use the previous status
+	// here to keep it as before, that maybe PullRequestStatusMergeable
 	if _, err := pull_service.SetMerged(ctx, pr, updates[len(updates)-1].NewCommitID, timeutil.TimeStampNow(), pusher, pr.Status); err != nil {
 		log.Error("Failed to update PR to merged: %v", err)
 		ctx.JSON(http.StatusInternalServerError, private.HookPostReceiveResult{Err: "Failed to update PR to merged"})

Original file line number	Diff line number	Diff line change
`@@ -357,6 +357,8 @@ func handlePullRequestMerging(ctx gitea_context.PrivateContext, opts private.H`
`357`	`357`	`return`
`358`	`358`	`}`
`359`	`359`
	`360`	+ // FIXME: Maybe we need a `PullRequestStatusMerged` status for PRs that are merged, currently we use the previous status
	`361`	`+ // here to keep it as before, that maybe PullRequestStatusMergeable`
`360`	`362`	`if _, err := pull_service.SetMerged(ctx, pr, updates[len(updates)-1].NewCommitID, timeutil.TimeStampNow(), pusher, pr.Status); err != nil {`
`361`	`363`	`log.Error("Failed to update PR to merged: %v", err)`
`362`	`364`	`ctx.JSON(http.StatusInternalServerError, private.HookPostReceiveResult{Err: "Failed to update PR to merged"})`