fix tests and typo

Author: TheFox0x7

cmd/admin_auth_ldap.go

@@ -138,11 +138,11 @@ var (
 		},
 		&cli.StringFlag{
 			Name:  "group-member-uid",
-			Usage: "Group attribte containing list of users",
+			Usage: "Group attribute containing list of users",
 		},
 		&cli.StringFlag{
 			Name:  "group-user-attribute",
-			Usage: "User attribte listed in group",
+			Usage: "User attribute listed in group",
 		},
 		&cli.StringFlag{
 			Name:  "group-filter",

cmd/admin_auth_ldap_test.go

@@ -51,11 +51,11 @@ func TestAddLdapBindDn(t *testing.T) {
 				"--attributes-in-bind",
 				"--synchronize-users",
 				"--page-size", "99",
-				"--enable-groups", "true",
+				"--enable-groups",
 				"--group-search-base", "ou=group,dc=full-domain-bind,dc=org",
 				"--group-member-uid", "memberUid",
 				"--group-user-attribute", "uid",
-				"--group-filter", "(|(cn=gitea_user)(cn=admins))",
+				"--group-filter", "(|(cn=gitea_users)(cn=admins))",
 				"--group-team-map", `{"cn=my-group,cn=groups,dc=example,dc=org": {"MyGiteaOrganization": ["MyGiteaTeam1", "MyGiteaTeam2"]}}`,
 				"--group-users-remove", "true",
 			},
@@ -524,6 +524,13 @@ func TestUpdateLdapBindDn(t *testing.T) {
 				"--bind-password", "secret-bind-full",
 				"--synchronize-users",
 				"--page-size", "99",
+				"--enable-groups",
+				"--group-search-base", "ou=group,dc=full-domain-bind,dc=org",
+				"--group-member-uid", "memberUid",
+				"--group-user-attribute", "uid",
+				"--group-filter", "(|(cn=gitea_users)(cn=admins))",
+				"--group-team-map", `{"cn=my-group,cn=groups,dc=example,dc=org": {"MyGiteaOrganization": ["MyGiteaTeam1", "MyGiteaTeam2"]}}`,
+				"--group-users-remove", "true",
 			},
 			id: 23,
 			existingAuthSource: &auth.Source{
@@ -559,6 +566,13 @@ func TestUpdateLdapBindDn(t *testing.T) {
 					AdminFilter:           "(memberOf=cn=admin-group,ou=example,dc=full-domain-bind,dc=org)",
 					RestrictedFilter:      "(memberOf=cn=restricted-group,ou=example,dc=full-domain-bind,dc=org)",
 					Enabled:               true,
+					GroupsEnabled:         true,
+					GroupDN:               "ou=group,dc=full-domain-bind,dc=org",
+					GroupMemberUID:        "memberUid",
+					UserUID:               "uid",
+					GroupFilter:           "(|(cn=gitea_users)(cn=admins))",
+					GroupTeamMap:          `{"cn=my-group,cn=groups,dc=example,dc=org": {"MyGiteaOrganization": ["MyGiteaTeam1", "MyGiteaTeam2"]}}`,
+					GroupTeamMapRemoval:   true,
 				},
 			},
 		},