Only display license on repository home page

Author: lunny

routers/web/repo/branch.go

@@ -24,7 +24,6 @@ import (
 	"code.gitea.io/gitea/modules/util"
 	"code.gitea.io/gitea/modules/web"
 	"code.gitea.io/gitea/routers/utils"
-	"code.gitea.io/gitea/routers/web/repo/shared"
 	"code.gitea.io/gitea/services/context"
 	"code.gitea.io/gitea/services/forms"
 	release_service "code.gitea.io/gitea/services/release"
@@ -47,10 +46,6 @@ func Branches(ctx *context.Context) {
 	ctx.Data["PageIsViewCode"] = true
 	ctx.Data["PageIsBranches"] = true
 
-	if !shared.PrepareForRepoSubMenu(ctx) {
-		return
-	}
-
 	page := ctx.FormInt("page")
 	if page <= 1 {
 		page = 1

routers/web/repo/commit.go

@@ -28,7 +28,6 @@ import (
 	"code.gitea.io/gitea/modules/markup"
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/util"
-	"code.gitea.io/gitea/routers/web/repo/shared"
 	"code.gitea.io/gitea/services/context"
 	"code.gitea.io/gitea/services/gitdiff"
 	repo_service "code.gitea.io/gitea/services/repository"
@@ -62,10 +61,6 @@ func Commits(ctx *context.Context) {
 	}
 	ctx.Data["PageIsViewCode"] = true
 
-	if !shared.PrepareForRepoSubMenu(ctx) {
-		return
-	}
-
 	commitsCount, err := ctx.Repo.GetCommitsCount()
 	if err != nil {
 		ctx.ServerError("GetCommitsCount", err)
@@ -201,10 +196,6 @@ func SearchCommits(ctx *context.Context) {
 	ctx.Data["PageIsCommits"] = true
 	ctx.Data["PageIsViewCode"] = true
 
-	if !shared.PrepareForRepoSubMenu(ctx) {
-		return
-	}
-
 	query := ctx.FormTrim("q")
 	if len(query) == 0 {
 		ctx.Redirect(ctx.Repo.RepoLink + "/commits/" + ctx.Repo.BranchNameSubURL())
@@ -233,10 +224,6 @@ func SearchCommits(ctx *context.Context) {
 
 // FileHistory show a file's reversions
 func FileHistory(ctx *context.Context) {
-	if !shared.PrepareForRepoSubMenu(ctx) {
-		return
-	}
-
 	fileName := ctx.Repo.TreePath
 	if len(fileName) == 0 {
 		Commits(ctx)

routers/web/repo/release.go

@@ -26,7 +26,6 @@ import (
 	"code.gitea.io/gitea/modules/util"
 	"code.gitea.io/gitea/modules/web"
 	"code.gitea.io/gitea/routers/web/feed"
-	"code.gitea.io/gitea/routers/web/repo/shared"
 	shared_user "code.gitea.io/gitea/routers/web/shared/user"
 	"code.gitea.io/gitea/services/context"
 	"code.gitea.io/gitea/services/context/upload"
@@ -157,13 +156,6 @@ func Releases(ctx *context.Context) {
 	ctx.Data["CanCreateBranch"] = false
 	ctx.Data["HideBranchesInDropdown"] = true
 
-	// repo/release_tag_header.tmpl will render sub menu depending on the different permission
-	if !ctx.Repo.CanRead(unit.TypeReleases) && ctx.Repo.CanRead(unit.TypeCode) {
-		if !shared.PrepareForRepoSubMenu(ctx) {
-			return
-		}
-	}
-
 	listOptions := db.ListOptions{
 		Page:     ctx.FormInt("page"),
 		PageSize: ctx.FormInt("limit"),
@@ -215,13 +207,6 @@ func TagsList(ctx *context.Context) {
 	ctx.Data["HideBranchesInDropdown"] = true
 	ctx.Data["CanCreateRelease"] = ctx.Repo.CanWrite(unit.TypeReleases) && !ctx.Repo.Repository.IsArchived
 
-	// repo/release_tag_header.tmpl will render sub menu depending on the different permission
-	if !ctx.Repo.CanRead(unit.TypeReleases) && ctx.Repo.CanRead(unit.TypeCode) {
-		if !shared.PrepareForRepoSubMenu(ctx) {
-			return
-		}
-	}
-
 	namePattern := ctx.FormTrim("q")
 
 	listOptions := db.ListOptions{

routers/web/repo/shared/sub_menu.go renamed to routers/web/repo/shared/license.go

@@ -9,13 +9,7 @@ import (
 	repo_service "code.gitea.io/gitea/services/repository"
 )
 
-// PrepareForRepoSubMenu will prepare all sub menus' data for some repositories pages
-// TODO: moving preparation for commits count, branches count, tags count and repository size to this function
-func PrepareForRepoSubMenu(ctx *context.Context) bool {
-	return prepareForLicenses(ctx)
-}
-
-func prepareForLicenses(ctx *context.Context) bool {
+func PrepareForLicenses(ctx *context.Context) bool {
 	repoLicenses, err := repo_model.GetRepoLicenses(ctx, ctx.Repo.Repository)
 	if err != nil {
 		ctx.ServerError("GetRepoLicenses", err)

routers/web/repo/view.go

@@ -981,7 +981,8 @@ func renderHomeCode(ctx *context.Context) {
 		return
 	}
 
-	if !shared.PrepareForRepoSubMenu(ctx) {
+	// only show licenses on repository's home page
+	if !shared.PrepareForLicenses(ctx) {
 		return
 	}