Skip to content

Commit 5eb89f4

Browse files
use db.withtx as per feedback
1 parent 4f8f5a2 commit 5eb89f4

File tree

1 file changed

+9
-26
lines changed

1 file changed

+9
-26
lines changed

services/user/badge.go

Lines changed: 9 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -13,36 +13,19 @@ import (
1313

1414
// UpdateBadgeDescription changes the description and/or image of a badge
1515
func UpdateBadge(ctx context.Context, b *user_model.Badge) error {
16-
ctx, committer, err := db.TxContext(ctx)
17-
if err != nil {
18-
return err
19-
}
20-
defer committer.Close()
21-
22-
if err := user_model.UpdateBadge(ctx, b); err != nil {
23-
return err
24-
}
25-
return committer.Commit()
16+
return db.WithTx(ctx, func(ctx context.Context) error {
17+
return user_model.UpdateBadge(ctx, b)
18+
})
2619
}
2720

2821
// DeleteBadge remove record of badge in the database
2922
func DeleteBadge(ctx context.Context, b *user_model.Badge) error {
30-
ctx, committer, err := db.TxContext(ctx)
31-
if err != nil {
32-
return err
33-
}
34-
defer committer.Close()
35-
36-
if err := user_model.DeleteBadge(ctx, b); err != nil {
37-
return fmt.Errorf("DeleteBadge: %w", err)
38-
}
39-
40-
if err := committer.Commit(); err != nil {
41-
return err
42-
}
43-
_ = committer.Close()
44-
45-
return nil
23+
return db.WithTx(ctx, func(ctx context.Context) error {
24+
if err := user_model.DeleteBadge(ctx, b); err != nil {
25+
return fmt.Errorf("DeleteBadge: %w", err)
26+
}
27+
return nil
28+
})
4629
}
4730

4831
// GetBadgeUsers returns the users that have a specific badge

0 commit comments

Comments
 (0)