Update comments

Author: lunny

services/repository/adopt.go

@@ -88,11 +88,12 @@ func AdoptRepository(ctx context.Context, doer, u *user_model.User, opts CreateR
 		return nil, fmt.Errorf("getRepositoryByID: %w", err)
 	}
 
-	// 3 - adopt the repository from disk
+	// 2 - adopt the repository from disk
 	if err = adoptRepository(ctx, repo, opts.DefaultBranch); err != nil {
 		return nil, fmt.Errorf("adoptRepository: %w", err)
 	}
 
+	// 3 - Update the git repository
 	if err = updateGitRepoAfterCreate(ctx, repo); err != nil {
 		return nil, fmt.Errorf("updateGitRepoAfterCreate: %w", err)
 	}

services/repository/create.go

@@ -272,6 +272,7 @@ func CreateRepositoryDirectly(ctx context.Context, doer, u *user_model.User, opt
 		return repo, nil
 	}
 
+	// 2 - check whether the repository with the same storage exists
 	var isExist bool
 	isExist, err = gitrepo.IsRepositoryExist(ctx, repo)
 	if err != nil {
@@ -288,29 +289,24 @@ func CreateRepositoryDirectly(ctx context.Context, doer, u *user_model.User, opt
 		return nil, err
 	}
 
+	// 3 - init git repository in storage
 	if err = initRepository(ctx, doer, repo, opts); err != nil {
 		return nil, fmt.Errorf("initRepository: %w", err)
 	}
 
-	// Initialize Issue Labels if selected
+	// 4 - Initialize Issue Labels if selected
 	if len(opts.IssueLabels) > 0 {
 		if err = repo_module.InitializeLabels(ctx, repo.ID, opts.IssueLabels, false); err != nil {
 			return nil, fmt.Errorf("InitializeLabels: %w", err)
 		}
 	}
 
+	// 5 - Update the git repository
 	if err = updateGitRepoAfterCreate(ctx, repo); err != nil {
 		return nil, fmt.Errorf("updateGitRepoAfterCreate: %w", err)
 	}
 
-	if needsUpdateStatus {
-		repo.Status = repo_model.RepositoryReady
-		if err = repo_model.UpdateRepositoryCols(ctx, repo, "status"); err != nil {
-			return nil, fmt.Errorf("UpdateRepositoryCols: %w", err)
-		}
-	}
-
-	// update licenses
+	// 6 - update licenses
 	var licenses []string
 	if len(opts.License) > 0 {
 		licenses = append(licenses, opts.License)
@@ -326,6 +322,14 @@ func CreateRepositoryDirectly(ctx context.Context, doer, u *user_model.User, opt
 		}
 	}
 
+	// 7 - update repository status to be ready
+	if needsUpdateStatus {
+		repo.Status = repo_model.RepositoryReady
+		if err = repo_model.UpdateRepositoryCols(ctx, repo, "status"); err != nil {
+			return nil, fmt.Errorf("UpdateRepositoryCols: %w", err)
+		}
+	}
+
 	return repo, nil
 }
 

services/repository/fork.go

@@ -128,6 +128,7 @@ func ForkRepository(ctx context.Context, doer, owner *user_model.User, opts Fork
 		}
 	}()
 
+	// 2 - check whether the repository with the same storage exists
 	var isExist bool
 	isExist, err = gitrepo.IsRepositoryExist(ctx, repo)
 	if err != nil {
@@ -144,7 +145,7 @@ func ForkRepository(ctx context.Context, doer, owner *user_model.User, opts Fork
 		return nil, err
 	}
 
-	// 2 - Clone the repository
+	// 3 - Clone the repository
 	cloneCmd := git.NewCommand("clone", "--bare")
 	if opts.SingleBranch != "" {
 		cloneCmd.AddArguments("--single-branch", "--branch").AddDynamicArguments(opts.SingleBranch)
@@ -156,17 +157,17 @@ func ForkRepository(ctx context.Context, doer, owner *user_model.User, opts Fork
 		return nil, fmt.Errorf("git clone: %w", err)
 	}
 
-	// 3 - Update the repository
+	// 4 - Update the git repository
 	if err = updateGitRepoAfterCreate(ctx, repo); err != nil {
 		return nil, fmt.Errorf("updateGitRepoAfterCreate: %w", err)
 	}
 
-	// 4 - Create hooks
+	// 5 - Create hooks
 	if err = gitrepo.CreateDelegateHooks(ctx, repo); err != nil {
 		return nil, fmt.Errorf("createDelegateHooks: %w", err)
 	}
 
-	// 5 - Sync the repository branches and tags
+	// 6 - Sync the repository branches and tags
 	var gitRepo *git.Repository
 	gitRepo, err = gitrepo.OpenRepository(ctx, repo)
 	if err != nil {
@@ -181,7 +182,7 @@ func ForkRepository(ctx context.Context, doer, owner *user_model.User, opts Fork
 		return nil, fmt.Errorf("Sync releases from git tags failed: %v", err)
 	}
 
-	// 6 - Update the repository
+	// 7 - Update the repository
 	// even if below operations failed, it could be ignored. And they will be retried
 	if err = repo_module.UpdateRepoSize(ctx, repo); err != nil {
 		log.Error("Failed to update size for repository: %v", err)
@@ -195,7 +196,7 @@ func ForkRepository(ctx context.Context, doer, owner *user_model.User, opts Fork
 		return nil, err
 	}
 
-	// 7 - update repository status to be ready
+	// 8 - update repository status to be ready
 	repo.Status = repo_model.RepositoryReady
 	if err = repo_model.UpdateRepositoryCols(ctx, repo, "status"); err != nil {
 		return nil, fmt.Errorf("UpdateRepositoryCols: %w", err)

services/repository/template.go

@@ -121,18 +121,19 @@ func GenerateRepository(ctx context.Context, doer, owner *user_model.User, templ
 		return nil, err
 	}
 
-	// 3 - Generate the git repository in storage
-	// Init git bare new repository.
+	// 3 -Init git bare new repository.
 	if err = git.InitRepository(ctx, generateRepo.RepoPath(), true, generateRepo.ObjectFormatName); err != nil {
 		return nil, fmt.Errorf("git.InitRepository: %w", err)
 	} else if err = gitrepo.CreateDelegateHooks(ctx, generateRepo); err != nil {
 		return nil, fmt.Errorf("createDelegateHooks: %w", err)
 	}
 
+	// 4 - Update the git repository
 	if err = updateGitRepoAfterCreate(ctx, generateRepo); err != nil {
 		return nil, fmt.Errorf("updateGitRepoAfterCreate: %w", err)
 	}
 
+	// 5 - generate the repository contents according to the template
 	// Git Content
 	if opts.GitContent && !templateRepo.IsEmpty {
 		if err = GenerateGitContent(ctx, templateRepo, generateRepo); err != nil {
@@ -181,7 +182,7 @@ func GenerateRepository(ctx context.Context, doer, owner *user_model.User, templ
 		}
 	}
 
-	// 4 - update repository status to be ready
+	// 6 - update repository status to be ready
 	generateRepo.Status = repo_model.RepositoryReady
 	if err = repo_model.UpdateRepositoryCols(ctx, generateRepo, "status"); err != nil {
 		return nil, fmt.Errorf("UpdateRepositoryCols: %w", err)