Fix duplicated notifier

lunny · lunny · commit 6061683f68ec · 2024-11-04T21:29:49.000-08:00
diff --git a/services/repository/commitstatus/commitstatus.go b/services/repository/commitstatus/commitstatus.go
@@ -97,9 +97,7 @@ func CreateCommitStatus(ctx context.Context, repo *repo_model.Repository, creato
 		return err
 	}
 
-	pushCommit := repo_module.CommitToPushCommit(commit)
-
-	notify.CreateCommitStatus(ctx, repo, pushCommit, creator, status)
+	notify.CreateCommitStatus(ctx, repo, repo_module.CommitToPushCommit(commit), creator, status)
 
 	defaultBranchCommit, err := gitRepo.GetBranchCommit(repo.DefaultBranch)
 	if err != nil {
@@ -112,8 +110,6 @@ func CreateCommitStatus(ctx context.Context, repo *repo_model.Repository, creato
 		}
 	}
 
-	notify.CreateCommitStatus(ctx, repo, repo_module.CommitToPushCommit(commit), creator, status)
-
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,7 @@ func CreateCommitStatus(ctx context.Context, repo *repo_model.Repository, creato`
`97`	`97`	`return err`
`98`	`98`	`}`
`99`	`99`
`100`		`- pushCommit := repo_module.CommitToPushCommit(commit)`
`101`		`-`
`102`		`- notify.CreateCommitStatus(ctx, repo, pushCommit, creator, status)`
	`100`	`+ notify.CreateCommitStatus(ctx, repo, repo_module.CommitToPushCommit(commit), creator, status)`
`103`	`101`
`104`	`102`	`defaultBranchCommit, err := gitRepo.GetBranchCommit(repo.DefaultBranch)`
`105`	`103`	`if err != nil {`
`@@ -112,8 +110,6 @@ func CreateCommitStatus(ctx context.Context, repo *repo_model.Repository, creato`
`112`	`110`	`}`
`113`	`111`	`}`
`114`	`112`
`115`		`- notify.CreateCommitStatus(ctx, repo, repo_module.CommitToPushCommit(commit), creator, status)`
`116`		`-`
`117`	`113`	`return nil`
`118`	`114`	`}`
`119`	`115`