Skip to content

Commit 60ae54f

Browse files
committed
Reword comment
1 parent 8ba7805 commit 60ae54f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

modules/graceful/manager_common.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ const (
2323
)
2424

2525
// LifecyclePProfLabel is a label marking manager lifecycle phase
26-
// Compliant with prometheus key regex
26+
// Making it compliant with prometheus key regex https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
27+
// would enable someone interested to be able to to continuously gather profiles into pyroscope.
28+
// Other labels for pprof (in "modules/process" package) should also follow this rule.
2729
const LifecyclePProfLabel = "graceful_lifecycle"
2830

2931
func statusMsg(msg string) systemdNotifyMsg {

0 commit comments

Comments
 (0)