fix: dont create empy PR through API

siccous · siccous · commit 6123ed49433f · 2024-12-02T12:23:19.000+01:00
diff --git a/routers/api/v1/repo/pull.go b/routers/api/v1/repo/pull.go
@@ -1240,6 +1240,13 @@ func parseCompareInfo(ctx *context.APIContext, form api.CreatePullRequestOption)
 		return nil, nil, nil, "", ""
 	}
 
+	if !(len(compareInfo.Commits) > 0) {
+		headGitRepo.Close()
+		ctx.Error(http.StatusUnprocessableEntity, "EmptyPullRequest",
+			fmt.Sprintf("no commits between %v:%v and %v:%v", baseRepo.Owner.Name, baseBranch, headUser.Name, headBranch))
+		return nil, nil, nil, "", ""
+	}
+
 	return headRepo, headGitRepo, compareInfo, baseBranch, headBranch
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1240,6 +1240,13 @@ func parseCompareInfo(ctx *context.APIContext, form api.CreatePullRequestOption)`
`1240`	`1240`	`return nil, nil, nil, "", ""`
`1241`	`1241`	`}`
`1242`	`1242`
	`1243`	`+ if !(len(compareInfo.Commits) > 0) {`
	`1244`	`+ headGitRepo.Close()`
	`1245`	`+ ctx.Error(http.StatusUnprocessableEntity, "EmptyPullRequest",`
	`1246`	`+ fmt.Sprintf("no commits between %v:%v and %v:%v", baseRepo.Owner.Name, baseBranch, headUser.Name, headBranch))`
	`1247`	`+ return nil, nil, nil, "", ""`
	`1248`	`+ }`
	`1249`	`+`
`1243`	`1250`	`return headRepo, headGitRepo, compareInfo, baseBranch, headBranch`
`1244`	`1251`	`}`
`1245`	`1252`