remove unnecessary tests

Author: wxiaoguang

models/fixtures/repository.yml

@@ -1694,19 +1694,6 @@
   is_fsck_enabled: true
   close_issues_via_commit_in_any_branch: false
 
--
-  id: 59
-  owner_id: 2
-  owner_name: user2
-  lower_name: test_commit_revert
-  name: test_commit_revert
-  default_branch: main
-  is_empty: false
-  is_archived: false
-  is_private: true
-  status: 0
-  num_issues: 0
-
 -
   id: 60
   owner_id: 40

tests/gitea-repositories-meta/user2/test_commit_revert.git/HEAD

@@ -200,7 +200,7 @@ func TestWebGitCommitEmail(t *testing.T) {
 
 		session := loginUser(t, user.Name)
 
-		makeReq := func(t *testing.T, link string, params map[string]string, expectedUserName, expectedEmail string) {
+		makeReq := func(t *testing.T, link string, params map[string]string, expectedUserName, expectedEmail string) *httptest.ResponseRecorder {
 			lastCommit := getLastCommit(t)
 			params["_csrf"] = GetUserCSRFToken(t, session)
 			params["last_commit"] = lastCommit.ID.String()
@@ -220,6 +220,7 @@ func TestWebGitCommitEmail(t *testing.T) {
 				assert.EqualValues(t, expectedUserName, newCommit.Committer.Name)
 				assert.EqualValues(t, expectedEmail, newCommit.Committer.Email)
 			}
+			return resp
 		}
 
 		uploadFile := func(t *testing.T, name, content string) string {
@@ -261,17 +262,18 @@ func TestWebGitCommitEmail(t *testing.T) {
 			}, "", "")
 		})
 
-		testWebGit := func(t *testing.T, linkForKeepPrivate string, paramsForKeepPrivate map[string]string, linkForChosenEmail string, paramsForChosenEmail map[string]string) {
+		testWebGit := func(t *testing.T, linkForKeepPrivate string, paramsForKeepPrivate map[string]string, linkForChosenEmail string, paramsForChosenEmail map[string]string) (resp1, resp2 *httptest.ResponseRecorder) {
 			t.Run("DefaultEmailKeepPrivate", func(t *testing.T) {
 				defer tests.PrintCurrentTest(t)()
 				paramsForKeepPrivate["commit_email"] = ""
-				makeReq(t, linkForKeepPrivate, paramsForKeepPrivate, "User Two", "[email protected]")
+				resp1 = makeReq(t, linkForKeepPrivate, paramsForKeepPrivate, "User Two", "[email protected]")
 			})
 			t.Run("ChooseEmail", func(t *testing.T) {
 				defer tests.PrintCurrentTest(t)()
 				paramsForChosenEmail["commit_email"] = "[email protected]"
-				makeReq(t, linkForChosenEmail, paramsForChosenEmail, "User Two", "[email protected]")
+				resp2 = makeReq(t, linkForChosenEmail, paramsForChosenEmail, "User Two", "[email protected]")
 			})
+			return resp1, resp2
 		}
 
 		t.Run("Edit", func(t *testing.T) {
@@ -324,10 +326,13 @@ index 0000000000..bbbbbbbbbb
 			require.NoError(t, err)
 			commit2, err := gitRepo.GetCommitByPath("patch-file-2.txt")
 			require.NoError(t, err)
-			testWebGit(t,
+			resp1, _ := testWebGit(t,
 				"/user2/repo1/_cherrypick/"+commit1.ID.String()+"/master", map[string]string{"revert": "true"},
 				"/user2/repo1/_cherrypick/"+commit2.ID.String()+"/master", map[string]string{"revert": "true"},
 			)
+
+			// By the way, test the "cherrypick" page: a successful revert redirects to the main branch
+			assert.EqualValues(t, "/user2/repo1/src/branch/master", resp1.Header().Get("Location"))
 		})
 	})
 }

tests/gitea-repositories-meta/user2/test_commit_revert.git/config

@@ -691,10 +691,6 @@ func TestOAuth_GrantScopesReadRepositoryFailOrganization(t *testing.T) {
 			FullRepoName: "user2/commitsonpr",
 			Private:      false,
 		},
-		{
-			FullRepoName: "user2/test_commit_revert",
-			Private:      true,
-		},
 	}
 	assert.Equal(t, reposExpected, reposCaptured)