Skip to content

Commit 62e21e8

Browse files
committed
Fix empty compare
1 parent 3dd9310 commit 62e21e8

File tree

2 files changed

+31
-1
lines changed

2 files changed

+31
-1
lines changed

routers/common/compare.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,10 @@ func ParseComparePathParams(ctx context.Context, pathParam string, baseRepo *rep
241241
var err error
242242

243243
if pathParam == "" {
244-
ci.HeadOriRef = baseRepo.DefaultBranch
244+
ci.CompareRouter = &CompareRouter{
245+
HeadOriRef: baseRepo.DefaultBranch,
246+
DotTimes: 3,
247+
}
245248
} else {
246249
ci.CompareRouter, err = parseCompareRouter(pathParam)
247250
if err != nil {

routers/common/compare_test.go

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,14 @@ func TestCompareRouters(t *testing.T) {
2121
router string
2222
compareRouter *CompareRouter
2323
}{
24+
{
25+
router: "",
26+
compareRouter: &CompareRouter{
27+
BaseOriRef: "",
28+
HeadOriRef: "",
29+
DotTimes: 3,
30+
},
31+
},
2432
{
2533
router: "main...develop",
2634
compareRouter: &CompareRouter{
@@ -175,6 +183,25 @@ func Test_ParseComparePathParams(t *testing.T) {
175183
router string
176184
compareInfo *CompareInfo
177185
}{
186+
{
187+
repoName: "repo1",
188+
router: "",
189+
compareInfo: &CompareInfo{
190+
CompareRouter: &CompareRouter{
191+
BaseOriRef: "master",
192+
BaseFullRef: git.RefNameFromBranch("master"),
193+
HeadOriRef: "master",
194+
HeadFullRef: git.RefNameFromBranch("master"),
195+
HeadOwnerName: repo1.OwnerName,
196+
HeadRepoName: repo1.Name,
197+
DotTimes: 3,
198+
},
199+
BaseRepo: repo1,
200+
HeadUser: repo1.Owner,
201+
HeadRepo: repo1,
202+
HeadGitRepo: gitRepo1,
203+
},
204+
},
178205
{
179206
repoName: "repo1",
180207
router: "master...branch2",

0 commit comments

Comments
 (0)