Skip to content

Commit 695cdb2

Browse files
author
coder1125
authored
Merge branch 'main' into AddInlineCommitComments
2 parents 57077ed + 463016b commit 695cdb2

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

.devcontainer/devcontainer.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
{
22
"name": "Gitea DevContainer",
33
"image": "mcr.microsoft.com/devcontainers/go:1.24-bookworm",
4+
"containerEnv": {
5+
// override "local" from packaged version
6+
"GOTOOLCHAIN": "auto"
7+
},
48
"features": {
59
// installs nodejs into container
610
"ghcr.io/devcontainers/features/node:1": {

models/issues/pull.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ import (
2929

3030
var ErrMustCollaborator = util.NewPermissionDeniedErrorf("user must be a collaborator")
3131

32+
const reviewedBy = "Reviewed-by: "
33+
3234
// ErrPullRequestNotExist represents a "PullRequestNotExist" kind of error.
3335
type ErrPullRequestNotExist struct {
3436
ID int64
@@ -348,7 +350,11 @@ type ReviewCount struct {
348350
func (pr *PullRequest) GetApprovalCounts(ctx context.Context) ([]*ReviewCount, error) {
349351
rCounts := make([]*ReviewCount, 0, 6)
350352
sess := db.GetEngine(ctx).Where("issue_id = ?", pr.IssueID)
351-
return rCounts, sess.Select("issue_id, type, count(id) as `count`").Where("official = ? AND dismissed = ?", true, false).GroupBy("issue_id, type").Table("review").Find(&rCounts)
353+
return rCounts, sess.Select("issue_id, type, count(id) as `count`").
354+
Where(builder.Eq{"official": true, "dismissed": false}).
355+
GroupBy("issue_id, type").
356+
Table("review").
357+
Find(&rCounts)
352358
}
353359

354360
// GetApprovers returns the approvers of the pull request
@@ -392,7 +398,7 @@ func (pr *PullRequest) getReviewedByLines(ctx context.Context, writer io.Writer)
392398
} else if review.Reviewer == nil {
393399
continue
394400
}
395-
if _, err := writer.Write([]byte("Reviewed-by: ")); err != nil {
401+
if _, err := writer.Write([]byte(reviewedBy)); err != nil {
396402
return err
397403
}
398404
if _, err := writer.Write([]byte(review.Reviewer.NewGitSig().String())); err != nil {

templates/repo/view_file.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
{{range $idx, $code := .FileContent}}
109109
{{$line := Eval $idx "+" 1}}
110110
<tr>
111-
<td id="L{{$line}}" class="lines-num"><span id="L{{$line}}" data-line-number="{{$line}}"></span></td>
111+
<td class="lines-num"><span id="L{{$line}}" data-line-number="{{$line}}"></span></td>
112112
{{if $.EscapeStatus.Escaped}}
113113
<td class="lines-escape">{{if (index $.LineEscapeStatus $idx).Escaped}}<button class="toggle-escape-button btn interact-bg" title="{{if (index $.LineEscapeStatus $idx).HasInvisible}}{{ctx.Locale.Tr "repo.invisible_runes_line"}} {{end}}{{if (index $.LineEscapeStatus $idx).HasAmbiguous}}{{ctx.Locale.Tr "repo.ambiguous_runes_line"}}{{end}}"></button>{{end}}</td>
114114
{{end}}

0 commit comments

Comments
 (0)