disable stringsbuilder and concat-loop

Author: silverwind

.golangci.yml

@@ -109,6 +109,11 @@ linters:
         - require-error
     usetesting:
       os-temp-dir: true
+    modernize:
+      disable:
+        - stringsbuilder
+    perfsprint:
+      concat-loop: false
   exclusions:
     generated: lax
     presets:

models/asymkey/ssh_key_parse.go

@@ -66,7 +66,6 @@ func parseKeyString(content string) (string, error) {
 		lines := strings.Split(content, "\n")
 		continuationLine := false
 
-		var keyContentSb strings.Builder
 		for _, line := range lines {
 			// Skip lines that:
 			// 1) are a continuation of the previous line,
@@ -75,10 +74,9 @@ func parseKeyString(content string) (string, error) {
 			if continuationLine || strings.ContainsAny(line, ":-") {
 				continuationLine = strings.HasSuffix(line, "\\")
 			} else {
-				keyContentSb.WriteString(line)
+				keyContent += line
 			}
 		}
-		keyContent += keyContentSb.String()
 
 		t, err := extractTypeFromBase64Key(keyContent)
 		if err != nil {

models/perm/access/repo_permission.go

@@ -8,7 +8,6 @@ import (
 	"errors"
 	"fmt"
 	"slices"
-	"strings"
 
 	actions_model "code.gitea.io/gitea/models/actions"
 	"code.gitea.io/gitea/models/db"
@@ -169,8 +168,7 @@ func (p *Permission) ReadableUnitTypes() []unit.Type {
 }
 
 func (p *Permission) LogString() string {
-	var formatSb strings.Builder
-	formatSb.WriteString("<Permission AccessMode=%s, %d Units, %d UnitsMode(s): [")
+	format := "<Permission AccessMode=%s, %d Units, %d UnitsMode(s): ["
 	args := []any{p.AccessMode.ToString(), len(p.units), len(p.unitsMode)}
 
 	for i, u := range p.units {
@@ -182,19 +180,19 @@ func (p *Permission) LogString() string {
 				config = err.Error()
 			}
 		}
-		formatSb.WriteString("\n\tunits[%d]: ID=%d RepoID=%d Type=%s Config=%s")
+		format += "\n\tunits[%d]: ID=%d RepoID=%d Type=%s Config=%s"
 		args = append(args, i, u.ID, u.RepoID, u.Type.LogString(), config)
 	}
 	for key, value := range p.unitsMode {
-		formatSb.WriteString("\n\tunitsMode[%-v]: %-v")
+		format += "\n\tunitsMode[%-v]: %-v"
 		args = append(args, key.LogString(), value.LogString())
 	}
-	formatSb.WriteString("\n\tanonymousAccessMode: %-v")
+	format += "\n\tanonymousAccessMode: %-v"
 	args = append(args, p.anonymousAccessMode)
-	formatSb.WriteString("\n\teveryoneAccessMode: %-v")
+	format += "\n\teveryoneAccessMode: %-v"
 	args = append(args, p.everyoneAccessMode)
-	formatSb.WriteString("\n\t]>")
-	return fmt.Sprintf(formatSb.String(), args...)
+	format += "\n\t]>"
+	return fmt.Sprintf(format, args...)
 }
 
 func applyPublicAccessPermission(unitType unit.Type, accessMode perm_model.AccessMode, modeMap *map[unit.Type]perm_model.AccessMode) {

modules/auth/password/password.go

@@ -61,23 +61,21 @@ func NewComplexity() {
 }
 
 func setupComplexity(values []string) {
-	var validCharsSb strings.Builder
 	if len(values) != 1 || values[0] != "off" {
 		for _, val := range values {
 			if complexity, ok := charComplexities[val]; ok {
-				validCharsSb.WriteString(complexity.ValidChars)
+				validChars += complexity.ValidChars
 				requiredList = append(requiredList, complexity)
 			}
 		}
 		if len(requiredList) == 0 {
 			// No valid character classes found; use all classes as default
 			for _, complexity := range charComplexities {
-				validCharsSb.WriteString(complexity.ValidChars)
+				validChars += complexity.ValidChars
 				requiredList = append(requiredList, complexity)
 			}
 		}
 	}
-	validChars = validCharsSb.String()
 	if validChars == "" {
 		// No complexities to check; provide a sensible default for password generation
 		validChars = charComplexities["lower"].ValidChars + charComplexities["upper"].ValidChars + charComplexities["digit"].ValidChars

modules/git/foreachref/format.go

@@ -75,9 +75,9 @@ func (f Format) Parser(r io.Reader) *Parser {
 // hexEscaped produces hex-escpaed characters from a string. For example, "\n\0"
 // would turn into "%0a%00".
 func (f Format) hexEscaped(delim []byte) string {
-	var escapedSb strings.Builder
+	escaped := ""
 	for i := range delim {
-		escapedSb.WriteString("%" + hex.EncodeToString([]byte{delim[i]}))
+		escaped += "%" + hex.EncodeToString([]byte{delim[i]})
 	}
-	return escapedSb.String()
+	return escaped
 }

modules/git/notes_nogogit.go

@@ -26,21 +26,22 @@ func GetNote(ctx context.Context, repo *Repository, commitID string, note *Note)
 		return err
 	}
 
+	path := ""
+
 	tree := &notes.Tree
 	log.Trace("Found tree with ID %q while searching for git note corresponding to the commit %q", tree.ID, commitID)
 
 	var entry *TreeEntry
 	originalCommitID := commitID
-	var pathSb strings.Builder
 	for len(commitID) > 2 {
 		entry, err = tree.GetTreeEntryByPath(commitID)
 		if err == nil {
-			pathSb.WriteString(commitID)
+			path += commitID
 			break
 		}
 		if IsErrNotExist(err) {
 			tree, err = tree.SubTree(commitID[0:2])
-			pathSb.WriteString(commitID[0:2] + "/")
+			path += commitID[0:2] + "/"
 			commitID = commitID[2:]
 		}
 		if err != nil {
@@ -51,7 +52,6 @@ func GetNote(ctx context.Context, repo *Repository, commitID string, note *Note)
 			return err
 		}
 	}
-	path := pathSb.String()
 
 	blob := entry.Blob()
 	dataRc, err := blob.DataAsync()

modules/setting/config.go

@@ -4,7 +4,6 @@
 package setting
 
 import (
-	"strings"
 	"sync"
 
 	"code.gitea.io/gitea/modules/log"
@@ -24,11 +23,11 @@ type OpenWithEditorApp struct {
 type OpenWithEditorAppsType []OpenWithEditorApp
 
 func (t OpenWithEditorAppsType) ToTextareaString() string {
-	var retSb strings.Builder
+	ret := ""
 	for _, app := range t {
-		retSb.WriteString(app.DisplayName + " = " + app.OpenURL + "\n")
+		ret += app.DisplayName + " = " + app.OpenURL + "\n"
 	}
-	return retSb.String()
+	return ret
 }
 
 func DefaultOpenWithEditorApps() OpenWithEditorAppsType {

modules/setting/config_env.go

@@ -48,20 +48,18 @@ func decodeEnvSectionKey(encoded string) (ok bool, section, key string) {
 	inKey := false
 	last := 0
 	escapeStringIndices := escapeRegex.FindAllStringIndex(encoded, -1)
-	var keySb strings.Builder
-	var sectionSb strings.Builder
 	for _, unescapeIdx := range escapeStringIndices {
 		preceding := encoded[last:unescapeIdx[0]]
 		if !inKey {
 			if splitter := strings.Index(preceding, "__"); splitter > -1 {
-				sectionSb.WriteString(preceding[:splitter])
+				section += preceding[:splitter]
 				inKey = true
-				keySb.WriteString(preceding[splitter+2:])
+				key += preceding[splitter+2:]
 			} else {
-				sectionSb.WriteString(preceding)
+				section += preceding
 			}
 		} else {
-			keySb.WriteString(preceding)
+			key += preceding
 		}
 		toDecode := encoded[unescapeIdx[0]+3 : unescapeIdx[1]-1]
 		decodedBytes := make([]byte, len(toDecode)/2)
@@ -71,14 +69,12 @@ func decodeEnvSectionKey(encoded string) (ok bool, section, key string) {
 			decodedBytes[i] = byte(byteInt)
 		}
 		if inKey {
-			keySb.Write(decodedBytes)
+			key += string(decodedBytes)
 		} else {
-			sectionSb.Write(decodedBytes)
+			section += string(decodedBytes)
 		}
 		last = unescapeIdx[1]
 	}
-	key = keySb.String()
-	section = sectionSb.String()
 	remaining := encoded[last:]
 	if !inKey {
 		if splitter := strings.Index(remaining, "__"); splitter > -1 {

modules/templates/util_render.go

@@ -249,18 +249,17 @@ func (ut *RenderUtils) MarkdownToHtml(input string) template.HTML { //nolint:rev
 func (ut *RenderUtils) RenderLabels(labels []*issues_model.Label, repoLink string, issue *issues_model.Issue) template.HTML {
 	isPullRequest := issue != nil && issue.IsPull
 	baseLink := fmt.Sprintf("%s/%s", repoLink, util.Iif(isPullRequest, "pulls", "issues"))
-	var htmlCodeSb strings.Builder
-	htmlCodeSb.WriteString(`<span class="labels-list">`)
+	htmlCode := `<span class="labels-list">`
 	for _, label := range labels {
 		// Protect against nil value in labels - shouldn't happen but would cause a panic if so
 		if label == nil {
 			continue
 		}
 		link := fmt.Sprintf("%s?labels=%d", baseLink, label.ID)
-		htmlCodeSb.WriteString(string(ut.RenderLabelWithLink(label, template.URL(link))))
+		htmlCode += string(ut.RenderLabelWithLink(label, template.URL(link)))
 	}
-	htmlCodeSb.WriteString("</span>")
-	return template.HTML(htmlCodeSb.String())
+	htmlCode += "</span>"
+	return template.HTML(htmlCode)
 }
 
 func (ut *RenderUtils) RenderThemeItem(info *webtheme.ThemeMetaInfo, iconSize int) template.HTML {

modules/timeutil/since.go

@@ -95,15 +95,14 @@ func timeSincePro(then, now time.Time, lang translation.Locale) string {
 		return lang.TrString("tool.now")
 	}
 
-	var diffStr string
-	var timeStrSb strings.Builder
+	var timeStr, diffStr string
 	for {
 		if diff == 0 {
 			break
 		}
 
 		diff, diffStr = computeTimeDiffFloor(diff, lang)
-		timeStrSb.WriteString(", " + diffStr)
+		timeStr += ", " + diffStr
 	}
-	return strings.TrimPrefix(timeStrSb.String(), ", ")
+	return strings.TrimPrefix(timeStr, ", ")
 }