rename CheckTaskID to CheckTaskIsRunning

Author: bohde

services/auth/oauth2.go

@@ -55,8 +55,8 @@ func CheckOAuthAccessToken(ctx context.Context, accessToken string) int64 {
 	return grant.UserID
 }
 
-// CheckTaskID verifies that the TaskID corresponds to a running task
-func CheckTaskID(ctx context.Context, taskID int64) bool {
+// CheckTaskIsRunning verifies that the TaskID corresponds to a running task
+func CheckTaskIsRunning(ctx context.Context, taskID int64) bool {
 	// Verify the task exists
 	task, err := actions_model.GetTaskByID(ctx, taskID)
 	if err != nil {
@@ -112,7 +112,7 @@ func (o *OAuth2) userIDFromToken(ctx context.Context, tokenSHA string, store Dat
 	if strings.Contains(tokenSHA, ".") {
 		// First attempt to decode an actions JWT, returning the actions user
 		if taskID, err := actions.TokenToTaskID(tokenSHA); err == nil {
-			if CheckTaskID(ctx, taskID) {
+			if CheckTaskIsRunning(ctx, taskID) {
 				store.GetData()["IsActionsToken"] = true
 				store.GetData()["ActionsTaskID"] = taskID
 				return user_model.ActionsUserID

services/auth/oauth2_test.go

@@ -33,7 +33,7 @@ func TestUserIDFromToken(t *testing.T) {
 	})
 }
 
-func TestCheckTaskID(t *testing.T) {
+func TestCheckTaskIsRunning(t *testing.T) {
 	assert.NoError(t, unittest.PrepareTestDatabase())
 
 	cases := map[string]struct {
@@ -48,7 +48,7 @@ func TestCheckTaskID(t *testing.T) {
 	for name := range cases {
 		c := cases[name]
 		t.Run(name, func(t *testing.T) {
-			actual := CheckTaskID(context.Background(), c.TaskID)
+			actual := CheckTaskIsRunning(context.Background(), c.TaskID)
 			assert.Equal(t, c.Expected, actual)
 		})
 	}