Prevent panic on empty HOST for mysql (#11850) (#11856)

zeripath · web-flow · commit 6b1e5f7f88d1 · 2020-06-11T14:27:59.000-04:00
Backport #11850 Signed-off-by: Andrew Thornton <art27@cantab.net>
diff --git a/modules/setting/database.go b/modules/setting/database.go
@@ -105,7 +105,7 @@ func DBConnStr() (string, error) {
 	switch Database.Type {
 	case "mysql":
 		connType := "tcp"
-		if Database.Host[0] == '/' { // looks like a unix socket
+		if len(Database.Host) > 0 && Database.Host[0] == '/' { // looks like a unix socket
 			connType = "unix"
 		}
 		tls := Database.SSLMode

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ func DBConnStr() (string, error) {`
`105`	`105`	`switch Database.Type {`
`106`	`106`	`case "mysql":`
`107`	`107`	`connType := "tcp"`
`108`		`- if Database.Host[0] == '/' { // looks like a unix socket`
	`108`	`+ if len(Database.Host) > 0 && Database.Host[0] == '/' { // looks like a unix socket`
`109`	`109`	`connType = "unix"`
`110`	`110`	`}`
`111`	`111`	`tls := Database.SSLMode`