more columns needs longtext

Author: lunny

models/migrations/migrations.go

@@ -385,7 +385,7 @@ func prepareMigrationTasks() []*migration {
 		newMigration(320, "Migrate two_factor_policy to login_source table", v1_24.MigrateSkipTwoFactor),
 
 		// Gitea 1.24.0 ends at database version 321
-		newMigration(321, "Fix review_state.updated_files column", v1_25.FixReviewStateUpdatedFilesColumn),
+		newMigration(321, "Use LONGTEXT for some columns and fix review_state.updated_files column", v1_25.UseLongTextInSomeColumnsAndFixBugs),
 	}
 	return preparedMigrations
 }

models/migrations/v1_25/v321.go

@@ -11,18 +11,42 @@ import (
 	"xorm.io/xorm/schemas"
 )
 
-func FixReviewStateUpdatedFilesColumn(x *xorm.Engine) error {
-	if setting.Database.Type == "sqlite3" {
-		return nil // SQLite does not support modify column type and the text type is already sufficient
+func UseLongTextInSomeColumnsAndFixBugs(x *xorm.Engine) error {
+	if !setting.Database.Type.IsMySQL() {
+		return nil // Only mysql need to change from text to long text, for other databases, they are the same
 	}
 
-	return base.ModifyColumn(x, "review_state", &schemas.Column{
+	if err := base.ModifyColumn(x, "review_state", &schemas.Column{
 		Name: "updated_files",
 		SQLType: schemas.SQLType{
 			Name: "LONGTEXT",
 		},
 		Length:         0,
 		Nullable:       false,
 		DefaultIsEmpty: true,
+	}); err != nil {
+		return err
+	}
+
+	if err := base.ModifyColumn(x, "package_property", &schemas.Column{
+		Name: "value",
+		SQLType: schemas.SQLType{
+			Name: "LONGTEXT",
+		},
+		Length:         0,
+		Nullable:       false,
+		DefaultIsEmpty: true,
+	}); err != nil {
+		return err
+	}
+
+	return base.ModifyColumn(x, "notice", &schemas.Column{
+		Name: "description",
+		SQLType: schemas.SQLType{
+			Name: "LONGTEXT",
+		},
+		Length:         0,
+		Nullable:       false,
+		DefaultIsEmpty: true,
 	})
 }

models/migrations/v1_25/v321_test.go

@@ -13,9 +13,9 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func Test_FixReviewStateUpdatedFilesColumn(t *testing.T) {
-	if setting.Database.Type == "sqlite3" {
-		t.Skip("SQLite does not support modify column type")
+func Test_UseLongTextInSomeColumnsAndFixBugs(t *testing.T) {
+	if !setting.Database.Type.IsMySQL() {
+		t.Skip("Only MySQL needs to change from TEXT to LONGTEXT")
 	}
 
 	type ReviewState struct {
@@ -27,16 +27,45 @@ func Test_FixReviewStateUpdatedFilesColumn(t *testing.T) {
 		UpdatedUnix  timeutil.TimeStamp `xorm:"updated"`                                           // Is an accurate indicator of the order of commits as we do not expect it to be possible to make reviews on previous commits
 	}
 
+	type PackageProperty struct {
+		ID      int64  `xorm:"pk autoincr"`
+		RefType int    `xorm:"INDEX NOT NULL"`
+		RefID   int64  `xorm:"INDEX NOT NULL"`
+		Name    string `xorm:"INDEX NOT NULL"`
+		Value   string `xorm:"TEXT NOT NULL"`
+	}
+
+	type Notice struct {
+		ID          int64 `xorm:"pk autoincr"`
+		Type        int
+		Description string             `xorm:"LONGTEXT"`
+		CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
+	}
+
 	// Prepare and load the testing database
-	x, deferable := base.PrepareTestEnv(t, 0, new(ReviewState))
+	x, deferable := base.PrepareTestEnv(t, 0, new(ReviewState), new(PackageProperty), new(Notice))
 	defer deferable()
 
-	assert.NoError(t, FixReviewStateUpdatedFilesColumn(x))
+	assert.NoError(t, UseLongTextInSomeColumnsAndFixBugs(x))
 
 	tableInfo, err := x.TableInfo(&ReviewState{})
 	assert.NoError(t, err)
 	assert.NotNil(t, tableInfo)
 	column := tableInfo.GetColumn("updated_files")
 	assert.NotNil(t, column)
 	assert.Equal(t, "LONGTEXT", column.SQLType.Name)
+
+	tableInfo, err = x.TableInfo(&PackageProperty{})
+	assert.NoError(t, err)
+	assert.NotNil(t, tableInfo)
+	column = tableInfo.GetColumn("value")
+	assert.NotNil(t, column)
+	assert.Equal(t, "LONGTEXT", column.SQLType.Name)
+
+	tableInfo, err = x.TableInfo(&Notice{})
+	assert.NoError(t, err)
+	assert.NotNil(t, tableInfo)
+	column = tableInfo.GetColumn("description")
+	assert.NotNil(t, column)
+	assert.Equal(t, "LONGTEXT", column.SQLType.Name)
 }

models/packages/package_property.go

@@ -32,7 +32,7 @@ type PackageProperty struct {
 	RefType PropertyType `xorm:"INDEX NOT NULL"`
 	RefID   int64        `xorm:"INDEX NOT NULL"`
 	Name    string       `xorm:"INDEX NOT NULL"`
-	Value   string       `xorm:"TEXT NOT NULL"`
+	Value   string       `xorm:"LONGTEXT NOT NULL"`
 }
 
 // InsertProperty creates a property

models/system/notice.go

@@ -29,7 +29,7 @@ const (
 type Notice struct {
 	ID          int64 `xorm:"pk autoincr"`
 	Type        NoticeType
-	Description string             `xorm:"TEXT"`
+	Description string             `xorm:"LONGTEXT"`
 	CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
 }