add tests

Author: wxiaoguang

models/auth/webauthn.go

@@ -197,13 +197,3 @@ func DeleteCredential(ctx context.Context, id, userID int64) (bool, error) {
 	had, err := db.GetEngine(ctx).ID(id).Where("user_id = ?", userID).Delete(&WebAuthnCredential{})
 	return had > 0, err
 }
-
-// WebAuthnCredentials implements the webauthn.User interface
-func WebAuthnCredentials(ctx context.Context, userID int64) ([]webauthn.Credential, error) {
-	dbCreds, err := GetWebAuthnCredentialsByUID(ctx, userID)
-	if err != nil {
-		return nil, err
-	}
-
-	return dbCreds.ToCredentials(), nil
-}

models/auth/webauthn_test.go

@@ -58,10 +58,24 @@ func TestWebAuthnCredential_UpdateLargeCounter(t *testing.T) {
 func TestCreateCredential(t *testing.T) {
 	assert.NoError(t, unittest.PrepareTestDatabase())
 
-	res, err := auth_model.CreateCredential(db.DefaultContext, 1, "WebAuthn Created Credential", &webauthn.Credential{ID: []byte("Test")})
+	flags := webauthn.CredentialFlags{
+		UserPresent:    true,
+		UserVerified:   true,
+		BackupEligible: true,
+		BackupState:    true,
+	}
+	res, err := auth_model.CreateCredential(db.DefaultContext, 1, "WebAuthn Created Credential", &webauthn.Credential{
+		ID:    []byte("Test"),
+		Flags: flags,
+	})
 	assert.NoError(t, err)
 	assert.Equal(t, "WebAuthn Created Credential", res.Name)
 	assert.Equal(t, []byte("Test"), res.CredentialID)
 
-	unittest.AssertExistsIf(t, true, &auth_model.WebAuthnCredential{Name: "WebAuthn Created Credential", UserID: 1})
+	webauthnUser1 := unittest.AssertExistsAndLoadBean(t, &auth_model.WebAuthnCredential{UserID: 1})
+	assert.Equal(t, "WebAuthn Created Credential", webauthnUser1.Name)
+	assert.Equal(t, []byte("Test"), webauthnUser1.CredentialID)
+
+	credList := auth_model.WebAuthnCredentialList{webauthnUser1}.ToCredentials()
+	assert.Equal(t, flags, credList[0].Flags)
 }