avoid nil access

Author: wxiaoguang

services/actions/clear_tasks.go

@@ -43,13 +43,15 @@ func notifyWorkflowJobStatusUpdate(ctx context.Context, jobs []*actions_model.Ac
 	for _, job := range jobs {
 		if err := job.LoadAttributes(ctx); err != nil {
 			log.Error("Failed to load job attributes: %v", err)
+			continue
 		}
 		CreateCommitStatusForRunJobs(ctx, job.Run, job)
 		notify_service.WorkflowJobStatusUpdate(ctx, job.Run.Repo, job.Run.TriggerUser, job, nil)
 	}
 
-	job := jobs[0]
-	notify_service.WorkflowRunStatusUpdate(ctx, job.Run.Repo, job.Run.TriggerUser, job.Run)
+	if job := jobs[0]; job.Run != nil && job.Run.Repo != nil {
+		notify_service.WorkflowRunStatusUpdate(ctx, job.Run.Repo, job.Run.TriggerUser, job.Run)
+	}
 }
 
 func CancelPreviousJobs(ctx context.Context, repoID int64, ref, workflowID string, event webhook_module.HookEventType) error {
@@ -212,8 +214,8 @@ func CancelAbandonedJobs(ctx context.Context) error {
 			log.Warn("cancel abandoned job %v: %v", job.ID, err)
 			// go on
 		}
-		if job.Run == nil {
-			continue // error occurs during loading attributes, the following code that depends on "Run" will fail, so ignore and skip
+		if job.Run == nil || job.Run.Repo == nil {
+			continue // error occurs during loading attributes, the following code that depends on "Run.Repo" will fail, so ignore and skip
 		}
 		CreateCommitStatusForRunJobs(ctx, job.Run, job)
 		if updated {

services/actions/commit_status.go

@@ -31,7 +31,7 @@ func CreateCommitStatusForRunJobs(ctx context.Context, run *actions_model.Action
 		return
 	}
 
-	event, commitID, err := getCommitStatusEventNameAndSHA(run)
+	event, commitID, err := getCommitStatusEventNameAndCommitID(run)
 	if err != nil {
 		log.Error("GetCommitStatusEventNameAndSHA: %v", err)
 	} else if event == "" || commitID == "" {
@@ -50,7 +50,7 @@ func CreateCommitStatusForRunJobs(ctx context.Context, run *actions_model.Action
 	}
 }
 
-func getCommitStatusEventNameAndSHA(run *actions_model.ActionRun) (event, sha string, _ error) {
+func getCommitStatusEventNameAndCommitID(run *actions_model.ActionRun) (event, commitID string, _ error) {
 	switch run.Event {
 	case webhook_module.HookEventPush:
 		event = "push"
@@ -61,7 +61,7 @@ func getCommitStatusEventNameAndSHA(run *actions_model.ActionRun) (event, sha st
 		if payload.HeadCommit == nil {
 			return "", "", errors.New("head commit is missing in event payload")
 		}
-		sha = payload.HeadCommit.ID
+		commitID = payload.HeadCommit.ID
 	case // pull_request
 		webhook_module.HookEventPullRequest,
 		webhook_module.HookEventPullRequestSync,
@@ -83,14 +83,13 @@ func getCommitStatusEventNameAndSHA(run *actions_model.ActionRun) (event, sha st
 		} else if payload.PullRequest.Head == nil {
 			return "", "", errors.New("head of pull request is missing in event payload")
 		}
-		sha = payload.PullRequest.Head.Sha
+		commitID = payload.PullRequest.Head.Sha
 	case webhook_module.HookEventRelease:
 		event = string(run.Event)
-		sha = run.CommitSHA
-	default:
-		return "", "", nil
+		commitID = run.CommitSHA
+	default: // do nothing, return empty
 	}
-	return event, sha, nil
+	return event, commitID, nil
 }
 
 func createCommitStatus(ctx context.Context, repo *repo_model.Repository, event, commitID string, run *actions_model.ActionRun, job *actions_model.ActionRunJob) error {