clean code

Author: kerwin612

services/forms/repo_form.go

@@ -627,7 +627,7 @@ type UpdateAllowEditsForm struct {
 //  |       _// __ \|  | _/ __ \\__  \  /  ___// __ \
 //  |    |   \  ___/|  |_\  ___/ / __ \_\___ \\  ___/
 //  |____|_  /\___  >____/\___  >____  /____  >\___  >
-//         \/     \/            \/     \/     \/     \/
+//         \/     \/          \/     \/     \/     \/
 
 // NewReleaseForm form for creating release
 type NewReleaseForm struct {

templates/repo/settings/webhook/settings.tmpl

@@ -54,7 +54,7 @@
 		<h5>{{ctx.Locale.Tr "repo.settings.payload_optimization_files"}}</h5>
 		<div class="field">
 			<div class="ui checkbox">
-				<input name="payload_optimization_files_enable" type="checkbox" {{if .Webhook.IsFilesOptimizationEnabled}}checked{{end}} onchange="toggleLimitField('payload_optimization_files_limit', this.checked)">
+				<input name="payload_optimization_files_enable" type="checkbox" {{if .Webhook.IsFilesOptimizationEnabled}}checked{{end}}>
 				<label>{{ctx.Locale.Tr "repo.settings.payload_optimization_enable"}}</label>
 				<span class="help">{{ctx.Locale.Tr "repo.settings.payload_optimization_enable_desc"}}</span>
 			</div>
@@ -69,7 +69,7 @@
 		<h5>{{ctx.Locale.Tr "repo.settings.payload_optimization_commits"}}</h5>
 		<div class="field">
 			<div class="ui checkbox">
-				<input name="payload_optimization_commits_enable" type="checkbox" {{if .Webhook.IsCommitsOptimizationEnabled}}checked{{end}} onchange="toggleLimitField('payload_optimization_commits_limit', this.checked)">
+				<input name="payload_optimization_commits_enable" type="checkbox" {{if .Webhook.IsCommitsOptimizationEnabled}}checked{{end}}>
 				<label>{{ctx.Locale.Tr "repo.settings.payload_optimization_enable"}}</label>
 				<span class="help">{{ctx.Locale.Tr "repo.settings.payload_optimization_enable_desc"}}</span>
 			</div>
@@ -82,15 +82,6 @@
 	</div>
 </div>
 
-<script>
-function toggleLimitField(fieldName, enabled) {
-	const field = document.querySelector('input[name="' + fieldName + '"]');
-	if (field) {
-		field.disabled = !enabled;
-	}
-}
-</script>
-
 <div class="field">
 	<h4>{{ctx.Locale.Tr "repo.settings.event_desc"}}</h4>
 	<div class="grouped event type fields">

web_src/js/features/repo-settings-webhook.ts

@@ -0,0 +1,32 @@
+/**
+ * Webhook settings functionality
+ */
+
+function toggleLimitField(fieldName: string, enabled: boolean): void {
+  const field = document.querySelector<HTMLInputElement>(`input[name="${fieldName}"]`);
+  if (field) {
+    field.disabled = !enabled;
+  }
+}
+
+export function initRepoSettingsWebhook(): void {
+  if (!document.querySelector('.page-content.repository.settings.webhook')) return;
+
+  // Add event listeners for payload optimization checkboxes
+  const filesEnableCheckbox = document.querySelector<HTMLInputElement>('input[name="payload_optimization_files_enable"]');
+  const commitsEnableCheckbox = document.querySelector<HTMLInputElement>('input[name="payload_optimization_commits_enable"]');
+
+  if (filesEnableCheckbox) {
+    filesEnableCheckbox.addEventListener('change', (e) => {
+      const target = e.target as HTMLInputElement;
+      toggleLimitField('payload_optimization_files_limit', target.checked);
+    });
+  }
+
+  if (commitsEnableCheckbox) {
+    commitsEnableCheckbox.addEventListener('change', (e) => {
+      const target = e.target as HTMLInputElement;
+      toggleLimitField('payload_optimization_commits_limit', target.checked);
+    });
+  }
+}

web_src/js/features/repo-settings.ts

@@ -3,6 +3,7 @@ import {createMonaco} from './codeeditor.ts';
 import {onInputDebounce, queryElems, toggleElem} from '../utils/dom.ts';
 import {POST} from '../modules/fetch.ts';
 import {initRepoSettingsBranchesDrag} from './repo-settings-branches.ts';
+import {initRepoSettingsWebhook} from './repo-settings-webhook.ts';
 import {fomanticQuery} from '../modules/fomantic/base.ts';
 
 const {appSubUrl, csrfToken} = window.config;
@@ -152,4 +153,5 @@ export function initRepoSettings() {
   initRepoSettingsSearchTeamBox();
   initRepoSettingsGitHook();
   initRepoSettingsBranchesDrag();
+  initRepoSettingsWebhook();
 }