rename error to avoid stutter

Author: TheFox0x7

routers/web/repo/repo.go

@@ -309,7 +309,7 @@ func handleActionError(ctx *context.Context, err error) {
 	case errors.Is(err, user_model.ErrBlockedUser):
 		ctx.Flash.Error(ctx.Tr("repo.action.blocked_user"))
 	case repo_service.IsRepositoryLimitReached(err):
-		limit := err.(repo_service.RepositoryLimitReachedError).Limit
+		limit := err.(repo_service.LimitReachedError).Limit
 		ctx.Flash.Error(ctx.TrN(limit, "repo.form.reach_limit_of_creation_1", "repo.form.reach_limit_of_creation_n", limit))
 	case errors.Is(err, util.ErrPermissionDenied):
 		ctx.HTTPError(http.StatusNotFound)

routers/web/repo/setting/setting.go

@@ -885,7 +885,7 @@ func handleSettingsPostTransfer(ctx *context.Context) {
 		} else if repo_model.IsErrRepoTransferInProgress(err) {
 			ctx.RenderWithErr(ctx.Tr("repo.settings.transfer_in_progress"), tplSettingsOptions, nil)
 		} else if repo_service.IsRepositoryLimitReached(err) {
-			limit := err.(repo_service.RepositoryLimitReachedError).Limit
+			limit := err.(repo_service.LimitReachedError).Limit
 			ctx.RenderWithErr(ctx.TrN(limit, "repo.form.reach_limit_of_creation_1", "repo.form.reach_limit_of_creation_n", limit), tplSettingsOptions, nil)
 		} else if errors.Is(err, user_model.ErrBlockedUser) {
 			ctx.RenderWithErr(ctx.Tr("repo.settings.transfer.blocked_user"), tplSettingsOptions, nil)

services/repository/transfer.go

@@ -25,14 +25,14 @@ import (
 	notify_service "code.gitea.io/gitea/services/notify"
 )
 
-type RepositoryLimitReachedError struct{ Limit int }
+type LimitReachedError struct{ Limit int }
 
-func (RepositoryLimitReachedError) Error() string {
+func (LimitReachedError) Error() string {
 	return "Repository limit has been reached"
 }
 
 func IsRepositoryLimitReached(err error) bool {
-	_, ok := err.(RepositoryLimitReachedError)
+	_, ok := err.(LimitReachedError)
 	return ok
 }
 
@@ -63,7 +63,7 @@ func AcceptTransferOwnership(ctx context.Context, repo *repo_model.Repository, d
 
 		if !doer.IsAdmin && !repoTransfer.Recipient.CanCreateRepo() {
 			limit := util.Iif(repoTransfer.Recipient.MaxRepoCreation >= 0, repoTransfer.Recipient.MaxRepoCreation, setting.Repository.MaxCreationLimit)
-			return RepositoryLimitReachedError{Limit: limit}
+			return LimitReachedError{Limit: limit}
 		}
 
 		if !repoTransfer.CanUserAcceptOrRejectTransfer(ctx, doer) {
@@ -418,7 +418,7 @@ func StartRepositoryTransfer(ctx context.Context, doer, newOwner *user_model.Use
 
 	if !doer.IsAdmin && !newOwner.CanCreateRepo() {
 		limit := util.Iif(newOwner.MaxRepoCreation >= 0, newOwner.MaxRepoCreation, setting.Repository.MaxCreationLimit)
-		return RepositoryLimitReachedError{Limit: limit}
+		return LimitReachedError{Limit: limit}
 	}
 
 	var isDirectTransfer bool