Fix successful return value for SyncAndGetUserSpecificDiff (#27152)

delvh · web-flow · commit 707c69f399d3 · 2023-09-20T22:28:17.000+02:00
A function should not return an error when it is successful. Otherwise, things like https://discord.com/channels/322538954119184384/322538954119184384/1153705341620600833 happen…
diff --git a/services/gitdiff/gitdiff.go b/services/gitdiff/gitdiff.go
@@ -1343,7 +1343,7 @@ outer:
 		}
 	}
 
-	return diff, err
+	return diff, nil
 }
 
 // CommentAsDiff returns c.Patch as *Diff

Original file line number	Diff line number	Diff line change
`@@ -1343,7 +1343,7 @@ outer:`
`1343`	`1343`	`}`
`1344`	`1344`	`}`
`1345`	`1345`
`1346`		`- return diff, err`
	`1346`	`+ return diff, nil`
`1347`	`1347`	`}`
`1348`	`1348`
`1349`	`1349`	`// CommentAsDiff returns c.Patch as *Diff`