use StatusCheckData for template

Author: Zettat123

routers/web/repo/pull.go

@@ -312,6 +312,14 @@ func prepareMergedViewPullInfo(ctx *context.Context, issue *issues_model.Issue)
 	return compareInfo
 }
 
+type pullCommitStatusCheckData struct {
+	MissingRequiredChecks []string
+	IsContextRequired     func(string) bool
+	RequireApproval       bool
+	CanApprove            bool
+	ApproveActionLink     string
+}
+
 // prepareViewPullInfo show meta information for a pull request preview page
 func prepareViewPullInfo(ctx *context.Context, issue *issues_model.Issue) *pull_service.CompareInfo {
 	ctx.Data["PullRequestWorkInProgressPrefixes"] = setting.Repository.PullRequest.WorkInProgressPrefixes
@@ -456,7 +464,11 @@ func prepareViewPullInfo(ctx *context.Context, issue *issues_model.Issue) *pull_
 		ctx.ServerError(fmt.Sprintf("GetRefCommitID(%s)", pull.GetGitHeadRefName()), err)
 		return nil
 	}
-	ctx.Data["SHA"] = sha
+
+	statusCheckData := &pullCommitStatusCheckData{
+		ApproveActionLink: fmt.Sprintf("%s/actions/approve-all-checks?sha=%s&redirect=%s", repo.Link(), sha, issue.Link()),
+	}
+	ctx.Data["StatusCheckData"] = statusCheckData
 
 	commitStatuses, err := git_model.GetLatestCommitStatus(ctx, repo.ID, sha, db.ListOptionsAll)
 	if err != nil {
@@ -474,11 +486,12 @@ func prepareViewPullInfo(ctx *context.Context, issue *issues_model.Issue) *pull_
 	}
 	for _, run := range runs {
 		if run.NeedApproval {
-			ctx.Data["RequireApproval"] = true
+			statusCheckData.RequireApproval = true
+			break
 		}
 	}
-	if ctx.Data["RequireApproval"] == true {
-		ctx.Data["CanApprove"] = ctx.Repo.CanWrite(unit.TypeActions)
+	if statusCheckData.RequireApproval {
+		statusCheckData.CanApprove = ctx.Repo.CanWrite(unit.TypeActions)
 	}
 
 	if len(commitStatuses) > 0 {
@@ -502,9 +515,9 @@ func prepareViewPullInfo(ctx *context.Context, issue *issues_model.Issue) *pull_
 				missingRequiredChecks = append(missingRequiredChecks, requiredContext)
 			}
 		}
-		ctx.Data["MissingRequiredChecks"] = missingRequiredChecks
+		statusCheckData.MissingRequiredChecks = missingRequiredChecks
 
-		ctx.Data["is_context_required"] = func(context string) bool {
+		statusCheckData.IsContextRequired = func(context string) bool {
 			for _, c := range pb.StatusCheckContexts {
 				if c == context {
 					return true

templates/repo/issue/view_content/pull_merge_box.tmpl

@@ -31,14 +31,8 @@
 		{{template "repo/pulls/status" (dict
 			"CommitStatus" .LatestCommitStatus
 			"CommitStatuses" .LatestCommitStatuses
-			"MissingRequiredChecks" .MissingRequiredChecks
 			"ShowHideChecks" true
-			"is_context_required" .is_context_required
-			"SHA" .SHA
-			"RequireApproval" .RequireApproval
-			"CanApprove" .CanApprove
-			"RepoLink" .RepoLink
-			"IssueLink" .Issue.Link
+			"StatusCheckData" .StatusCheckData
 		)}}
 		</div>
 		{{end}}

templates/repo/pulls/status.tmpl

@@ -1,9 +1,13 @@
 {{/* Template Attributes:
 * CommitStatus: summary of all commit status state
 * CommitStatuses: all commit status elements
-* MissingRequiredChecks: commit check contexts that are required by branch protection but not present
 * ShowHideChecks: whether use a button to show/hide the checks
-* is_context_required: Used in pull request commit status check table
+* StatusCheckData: additional status check data for repo/issue/view_content/pull_merge_box
+  - MissingRequiredChecks: list of missing required checks
+  - IsContextRequired: function to check whether a context is required
+  - RequireApproval: whether approval is required for workflow runs
+  - CanApprove: whether the user can approve workflow runs
+  - ApproveActionLink: link to approve all checks
 */}}
 
 {{if .CommitStatus}}
@@ -24,10 +28,9 @@
 		{{end}}
 
 		<div class="ui right">
-			{{if and .RequireApproval .CanApprove}}
-				<form method="post" action="{{.RepoLink}}/actions/approve-all-checks?redirect={{.IssueLink}}">
+			{{if and .StatusCheckData .StatusCheckData.RequireApproval .StatusCheckData.CanApprove}}
+				<form method="post" action="{{.StatusCheckData.ApproveActionLink}}">
 					{{ctx.RootData.CsrfTokenHtml}}
-					<input type="hidden" name="sha" value="{{.SHA}}">
 					<button type="submit" class="ui basic small compact button">
 						{{ctx.Locale.Tr "repo.pulls.status_checks_approve_all"}}
 					</button>
@@ -48,19 +51,21 @@
 				{{template "repo/commit_status" .}}
 				<div class="status-context gt-ellipsis">{{.Context}} <span class="text light-2">{{.Description}}</span></div>
 				<div class="ui status-details">
-					{{if $.is_context_required}}
-						{{if (call $.is_context_required .Context)}}<div class="ui label">{{ctx.Locale.Tr "repo.pulls.status_checks_requested"}}</div>{{end}}
+					{{if and $.StatusCheckData $.StatusCheckData.IsContextRequired}}
+						{{if (call $.StatusCheckData.IsContextRequired .Context)}}<div class="ui label">{{ctx.Locale.Tr "repo.pulls.status_checks_requested"}}</div>{{end}}
 					{{end}}
 					<span>{{if .TargetURL}}<a href="{{.TargetURL}}">{{ctx.Locale.Tr "repo.pulls.status_checks_details"}}</a>{{end}}</span>
 				</div>
 			</div>
 		{{end}}
-		{{range .MissingRequiredChecks}}
-			<div class="commit-status-item">
-				{{svg "octicon-dot-fill" 18 "commit-status icon text yellow"}}
-				<div class="status-context gt-ellipsis">{{.}}</div>
-				<div class="ui label">{{ctx.Locale.Tr "repo.pulls.status_checks_requested"}}</div>
-			</div>
+		{{if .StatusCheckData}}
+			{{range .StatusCheckData.MissingRequiredChecks}}
+				<div class="commit-status-item">
+					{{svg "octicon-dot-fill" 18 "commit-status icon text yellow"}}
+					<div class="status-context gt-ellipsis">{{.}}</div>
+					<div class="ui label">{{ctx.Locale.Tr "repo.pulls.status_checks_requested"}}</div>
+				</div>
+			{{end}}
 		{{end}}
 	</div>
 </div>