Fix bug and test

Author: lunny

routers/common/actions.go

@@ -39,11 +39,8 @@ func DownloadActionsRunJobLogs(ctx *context.Base, ctxRepo *repo_model.Repository
 	}
 
 	var curJob *actions_model.ActionRunJob
-	for _, job := range runJobs {
-		if job.ID == jobIndex {
-			curJob = job
-			break
-		}
+	if jobIndex >= 0 && jobIndex < int64(len(runJobs)) {
+		curJob = runJobs[jobIndex]
 	}
 	if curJob == nil {
 		ctx.HTTPError(http.StatusNotFound)

tests/integration/actions_log_test.go

@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"net/http"
 	"net/url"
+	"strconv"
 	"strings"
 	"testing"
 	"time"
@@ -149,8 +150,9 @@ jobs:
 					)
 				}
 
+				runID, _ := strconv.ParseInt(task.Context.GetFields()["run_id"].GetStringValue(), 10, 64)
 				// download task logs from API and check content
-				req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/repos/%s/%s/actions/runs/%s/jobs/0/logs", user2.Name, repo.Name, runIndex)).
+				req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/repos/%s/%s/actions/runs/%d/jobs/0/logs", user2.Name, repo.Name, runID)).
 					AddTokenAuth(token)
 				resp = MakeRequest(t, req, http.StatusOK)
 				logTextLines = strings.Split(strings.TrimSpace(resp.Body.String()), "\n")