Skip to content

Commit 75e7f7e

Browse files
committed
add FIXME for API GitDiff
1 parent 4a9d768 commit 75e7f7e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

routers/api/v1/repo/pull.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1591,6 +1591,8 @@ func GetPullRequestFiles(ctx *context.APIContext) {
15911591
maxLines := setting.Git.MaxGitDiffLines
15921592

15931593
// FIXME: If there are too many files in the repo, may cause some unpredictable issues.
1594+
// FIXME: when using "skip-to", the NumFiles (totalNumberOfFiles, totalNumberOfPages) will be wrong
1595+
// FIXME: it doesn't need to call "GetDiff" to do various parsing and hightlighting
15941596
diff, err := gitdiff.GetDiff(ctx, baseGitRepo,
15951597
&gitdiff.DiffOptions{
15961598
BeforeCommitID: startCommitID,

0 commit comments

Comments
 (0)