Fix bug

Author: lunny

modules/setting/ssh.go

@@ -4,6 +4,7 @@
 package setting
 
 import (
+	"os"
 	"path/filepath"
 	"strings"
 	"text/template"
@@ -134,6 +135,11 @@ func loadSSHFrom(rootCfg ConfigProvider) {
 		}
 	}
 
+	// FIXME: why 0o644 for a directory .....
+	if err := os.MkdirAll(GetSSHKeyTestPath(), 0o644); err != nil {
+		log.Fatal("failed to create directory %q for ssh key test: %w", GetSSHKeyTestPath(), err)
+	}
+
 	SSH.KeygenPath = sec.Key("SSH_KEYGEN_PATH").String()
 	SSH.Port = sec.Key("SSH_PORT").MustInt(22)
 	SSH.ListenPort = sec.Key("SSH_LISTEN_PORT").MustInt(SSH.Port)

modules/ssh/init.go

@@ -32,11 +32,6 @@ func Init() error {
 
 	builtinUnused()
 
-	// FIXME: why 0o644 for a directory .....
-	if err := os.MkdirAll(setting.GetSSHKeyTestPath(), 0o644); err != nil {
-		return fmt.Errorf("failed to create directory %q for ssh key test: %w", setting.GetSSHKeyTestPath(), err)
-	}
-
 	if len(setting.SSH.TrustedUserCAKeys) > 0 && setting.SSH.AuthorizedPrincipalsEnabled {
 		caKeysFileName := setting.SSH.TrustedUserCAKeysFile
 		caKeysFileDir := filepath.Dir(caKeysFileName)