feedback deletebyid

ChristopherHX · ChristopherHX · commit 79146cfa0204 · 2025-03-13T17:26:13.000+01:00
diff --git a/services/actions/task.go b/services/actions/task.go
@@ -35,7 +35,7 @@ func PickTask(ctx context.Context, runner *actions_model.ActionRunner) (*runnerv
 				return nil, false, nil
 			}
 			// task has been finished, remove it
-			_, err = db.GetEngine(ctx).Delete(runner)
+			_, err = db.DeleteByID[actions_model.ActionRunner](ctx, runner.ID)
 			if err != nil {
 				return nil, false, err
 			}

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ func PickTask(ctx context.Context, runner actions_model.ActionRunner) (runnerv`
`35`	`35`	`return nil, false, nil`
`36`	`36`	`}`
`37`	`37`	`// task has been finished, remove it`
`38`		`- _, err = db.GetEngine(ctx).Delete(runner)`
	`38`	`+ _, err = db.DeleteByID[actions_model.ActionRunner](ctx, runner.ID)`
`39`	`39`	`if err != nil {`
`40`	`40`	`return nil, false, err`
`41`	`41`	`}`