improve

Author: yp05327

modules/git/command.go

@@ -472,8 +472,11 @@ func AllowLFSFiltersArgs() TrustedCmdArgs {
 // see: https://github.com/go-gitea/gitea/issues/32889#issuecomment-2571848216
 // Should not add sapce in the end, sometimes git will add a `:`.
 func IsRemoteNotExistError(err error) bool {
+	// for git < 2.30
 	prefix := "exit status 128 - fatal: No such remote"
-	if DefaultFeatures().NewExitStatusForRemoteNotExist {
+
+	// for git >= 2.30
+	if DefaultFeatures().CheckVersionAtLeast("2.30") {
 		prefix = "exit status 2 - error: No such remote"
 	}
 	return strings.HasPrefix(err.Error(), prefix)

modules/git/git.go

@@ -26,11 +26,10 @@ const RequiredVersion = "2.0.0" // the minimum Git version required
 type Features struct {
 	gitVersion *version.Version
 
-	UsingGogit                     bool
-	SupportProcReceive             bool           // >= 2.29
-	SupportHashSha256              bool           // >= 2.42, SHA-256 repositories no longer an ‘experimental curiosity’
-	SupportedObjectFormats         []ObjectFormat // sha1, sha256
-	NewExitStatusForRemoteNotExist bool           // >= 2.30
+	UsingGogit             bool
+	SupportProcReceive     bool           // >= 2.29
+	SupportHashSha256      bool           // >= 2.42, SHA-256 repositories no longer an ‘experimental curiosity’
+	SupportedObjectFormats []ObjectFormat // sha1, sha256
 }
 
 var (
@@ -78,7 +77,6 @@ func loadGitVersionFeatures() (*Features, error) {
 	if features.SupportHashSha256 {
 		features.SupportedObjectFormats = append(features.SupportedObjectFormats, Sha256ObjectFormat)
 	}
-	features.NewExitStatusForRemoteNotExist = features.CheckVersionAtLeast("2.30")
 	return features, nil
 }