fix

Author: wxiaoguang

options/locale/locale_en-US.ini

@@ -3426,8 +3426,7 @@ config.disable_gravatar = Disable Gravatar
 config.enable_federated_avatar = Enable Federated Avatars
 config.open_with_editor_app_help = The "Open with" editors for the clone menu. If left empty, the default will be used. Expand to see the default.
 
-config.git_guide = Git Guide
-config.git_guide.remote_name = Git Remote Name
+config.git_guide_remote_name = Repository remote name for git commands in the guide
 
 config.git_config = Git Configuration
 config.git_disable_diff_highlight = Disable Diff Syntax Highlight

routers/web/admin/config.go

@@ -196,8 +196,6 @@ func ConfigSettings(ctx *context.Context) {
 }
 
 func ChangeConfig(ctx *context.Context) {
-	key := strings.TrimSpace(ctx.FormString("key"))
-	value := ctx.FormString("value")
 	cfg := setting.Config()
 
 	marshalBool := func(v string) (string, error) { //nolint:unparam // error is always nil
@@ -248,21 +246,38 @@ func ChangeConfig(ctx *context.Context) {
 		cfg.Repository.OpenWithEditorApps.DynKey(): marshalOpenWithApps,
 		cfg.Template.GitRemoteName.DynKey():        marshalString,
 	}
-	marshaller, hasMarshaller := marshallers[key]
-	if !hasMarshaller {
-		ctx.JSONError(ctx.Tr("admin.config.set_setting_failed", key))
-		return
-	}
-	marshaledValue, err := marshaller(value)
-	if err != nil {
-		ctx.JSONError(ctx.Tr("admin.config.set_setting_failed", key))
-		return
-	}
-	if err = system_model.SetSettings(ctx, map[string]string{key: marshaledValue}); err != nil {
-		ctx.JSONError(ctx.Tr("admin.config.set_setting_failed", key))
-		return
+
+	_ = ctx.Req.ParseForm()
+	queryKeys := ctx.Req.Form["key"]
+	queryValues := ctx.Req.Form["value"]
+loop:
+	for i, key := range queryKeys {
+		if i >= len(queryValues) {
+			ctx.JSONError(ctx.Tr("admin.config.set_setting_failed", key))
+			break loop
+		}
+		value := queryValues[i]
+
+		marshaller, hasMarshaller := marshallers[key]
+		if !hasMarshaller {
+			ctx.JSONError(ctx.Tr("admin.config.set_setting_failed", key))
+			break loop
+		}
+
+		marshaledValue, err := marshaller(value)
+		if err != nil {
+			ctx.JSONError(ctx.Tr("admin.config.set_setting_failed", key))
+			break loop
+		}
+
+		if err = system_model.SetSettings(ctx, map[string]string{key: marshaledValue}); err != nil {
+			ctx.JSONError(ctx.Tr("admin.config.set_setting_failed", key))
+			break loop
+		}
 	}
 
 	config.GetDynGetter().InvalidateCache()
-	ctx.JSONOK()
+	if !ctx.Written() {
+		ctx.JSONOK()
+	}
 }

templates/admin/config_settings.tmpl

@@ -24,30 +24,22 @@
 	{{ctx.Locale.Tr "repository"}}
 </h4>
 <div class="ui attached segment">
-	<form class="ui form form-fetch-action" method="post" action="{{AppSubUrl}}/-/admin/config?key={{.SystemConfig.Repository.OpenWithEditorApps.DynKey}}">
+	<form class="ui form form-fetch-action" method="post" action="{{AppSubUrl}}/-/admin/config">
 		<div class="field">
 			<details>
 				<summary>{{ctx.Locale.Tr "admin.config.open_with_editor_app_help"}}</summary>
 				<pre class="tw-px-4">{{.DefaultOpenWithEditorAppsString}}</pre>
 			</details>
 		</div>
 		<div class="field">
+			<input type="hidden" name="key" value="{{.SystemConfig.Repository.OpenWithEditorApps.DynKey}}">
 			<textarea name="value">{{(.SystemConfig.Repository.OpenWithEditorApps.Value ctx).ToTextareaString}}</textarea>
 		</div>
-		<div class="field">
-			<button class="ui primary button">{{ctx.Locale.Tr "save"}}</button>
-		</div>
-	</form>
-</div>
 
-<h4 class="ui top attached header">
-	{{ctx.Locale.Tr "admin.config.git_guide"}}
-</h4>
-<div class="ui attached segment">
-	<form class="ui form form-fetch-action" method="post" action="{{AppSubUrl}}/-/admin/config?key={{.SystemConfig.Template.GitRemoteName.DynKey}}">
-		<div class="field" data-field-patched="true">
-			<label for="remote_name">{{ctx.Locale.Tr "admin.config.git_guide.remote_name"}}</label>
-			<input id="remote_name" name="value" value="{{.SystemConfig.Template.GitRemoteName.Value ctx}}" maxlength="100" dir="auto" required>
+		<div class="field">
+			<label>{{ctx.Locale.Tr "admin.config.git_guide_remote_name"}}</label>
+			<input type="hidden" name="key" value="{{.SystemConfig.Template.GitRemoteName.DynKey}}">
+			<input name="value" value="{{.SystemConfig.Template.GitRemoteName.Value ctx}}" maxlength="100" dir="auto" required pattern="^[A-Za-z0-9][\-_A-Za-z0-9]*$">
 		</div>
 		<div class="field">
 			<button class="ui primary button">{{ctx.Locale.Tr "save"}}</button>