Some improvements

Author: lunny

models/issues/issue.go

@@ -513,16 +513,16 @@ func FindLatestIssues(ctx context.Context, repoID int64, isPull optional.Option[
 	issues := make([]*Issue, 0, pageSize)
 	err := db.GetEngine(ctx).Where("repo_id = ?", repoID).
 		And(isPullToCond(isPull)).
-		OrderBy("created_unix DESC").
+		OrderBy("updated_unix DESC").
 		Limit(pageSize).
 		Find(&issues)
 	return issues, err
 }
 
-func FindIssuesSuggestionByKeyword(ctx context.Context, repoID int64, keyword string, isPull optional.Option[bool], nonID int64, pageSize int) (IssueList, error) {
+func FindIssuesSuggestionByKeyword(ctx context.Context, repoID int64, keyword string, isPull optional.Option[bool], excludedID int64, pageSize int) (IssueList, error) {
 	cond := builder.NewCond()
-	if nonID > 0 {
-		cond = cond.And(builder.Neq{"`id`": nonID})
+	if excludedID > 0 {
+		cond = cond.And(builder.Neq{"`id`": excludedID})
 	}
 	cond = cond.And(builder.Expr("name LIKE ?", "%"+keyword+"%"))
 

services/issue/suggestion.go

@@ -25,19 +25,19 @@ func GetSuggestion(ctx context.Context, repo *repo_model.Repository, isPull opti
 	} else {
 		indexKeyword, _ := strconv.ParseInt(keyword, 10, 64)
 		var issue *issues_model.Issue
-		var nonID int64
+		var excludedID int64
 		if indexKeyword > 0 {
 			issue, err = issues_model.GetIssueByIndex(ctx, repo.ID, indexKeyword)
 			if err != nil && !issues_model.IsErrIssueNotExist(err) {
 				return nil, err
 			}
 			if issue != nil {
-				nonID = issue.ID
+				excludedID = issue.ID
 				pageSize--
 			}
 		}
 
-		issues, err = issues_model.FindIssuesSuggestionByKeyword(ctx, repo.ID, keyword, isPull, nonID, pageSize)
+		issues, err = issues_model.FindIssuesSuggestionByKeyword(ctx, repo.ID, keyword, isPull, excludedID, pageSize)
 		if err != nil {
 			return nil, err
 		}