fix(actions): fix nil errors and double list size

Author: TheFox0x7

go.mod

@@ -102,6 +102,7 @@ require (
 	github.com/prometheus/client_golang v1.20.5
 	github.com/quasoft/websspi v1.1.2
 	github.com/redis/go-redis/v9 v9.7.0
+	github.com/rhysd/actionlint v1.7.3
 	github.com/robfig/cron/v3 v3.0.1
 	github.com/santhosh-tekuri/jsonschema/v5 v5.3.1
 	github.com/sassoftware/go-rpmutils v0.4.0
@@ -271,7 +272,6 @@ require (
 	github.com/prometheus/client_model v0.6.1 // indirect
 	github.com/prometheus/common v0.60.1 // indirect
 	github.com/prometheus/procfs v0.15.1 // indirect
-	github.com/rhysd/actionlint v1.7.3 // indirect
 	github.com/rivo/uniseg v0.4.7 // indirect
 	github.com/rogpeppe/go-internal v1.13.1 // indirect
 	github.com/rs/xid v1.6.0 // indirect

modules/actions/jobparser/interpeter.go

@@ -9,10 +9,10 @@ import (
 	"gopkg.in/yaml.v3"
 )
 
-// NewInterpeter returns an interpeter used in the server,
+// NewInterpreter returns an interpreter used in the server,
 // need github, needs, strategy, matrix, inputs context only,
 // see https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
-func NewInterpeter(
+func NewInterpreter(
 	jobID string,
 	job *model.Job,
 	matrix map[string]any,
@@ -78,7 +78,7 @@ func NewInterpeter(
 	return exprparser.NewInterpeter(ee, config)
 }
 
-// JobResult is the minimum requirement of job results for Interpeter
+// JobResult is the minimum requirement of job results for Interpreter
 type JobResult struct {
 	Needs   []string
 	Result  string

modules/actions/jobparser/jobparser.go

@@ -54,7 +54,7 @@ func Parse(content []byte, options ...ParseOption) ([]*SingleWorkflow, error) {
 				job.Name = id
 			}
 			job.Strategy.RawMatrix = encodeMatrix(matrix)
-			evaluator := NewExpressionEvaluator(NewInterpeter(id, origin.GetJob(id), matrix, pc.gitContext, results, pc.vars))
+			evaluator := NewExpressionEvaluator(NewInterpreter(id, origin.GetJob(id), matrix, pc.gitContext, results, pc.vars))
 			job.Name = nameWithMatrix(job.Name, matrix, evaluator)
 			runsOn := origin.GetJob(id).RunsOn()
 			for i, v := range runsOn {

modules/actions/jobparser/model.go

@@ -204,16 +204,19 @@ func (evt *Event) Acts() map[string][]string {
 // Helper to convert actionlint errors
 func acErrToError(acErrs []*actionlint.Error) []error {
 	errs := make([]error, len(acErrs))
-	for _, err := range acErrs {
-		errs = append(errs, err)
+	for i, err := range acErrs {
+		errs[i] = err
 	}
 	return errs
 }
 
 func acStringToString(strs []*actionlint.String) []string {
+	if len(strs) == 0 {
+		return nil
+	}
 	strings := make([]string, len(strs))
-	for _, v := range strs {
-		strings = append(strings, v.Value)
+	for i, v := range strs {
+		strings[i] = v.Value
 	}
 	return strings
 }
@@ -246,29 +249,39 @@ func GetEventsFromContent(content []byte) ([]*Event, error) {
 	for _, acEvent := range wf.On {
 		event := &Event{
 			Name: acEvent.EventName(),
-			acts: map[string][]string{},
 		}
 		switch e := acEvent.(type) {
 		case *actionlint.ScheduledEvent:
 			schedules := make([]map[string]string, len(e.Cron))
-			for _, c := range e.Cron {
-				schedules = append(schedules, map[string]string{"cron": c.Value})
+			for i, c := range e.Cron {
+				schedules[i] = map[string]string{"cron": c.Value}
 			}
 			event.schedules = schedules
 		case *actionlint.WorkflowDispatchEvent:
 			inputs := make([]WorkflowDispatchInput, len(e.Inputs))
+			i := 0
 			for keyword, v := range e.Inputs {
-				inputs = append(inputs, WorkflowDispatchInput{
-					Name:        keyword,
-					Required:    v.Required.Value,
-					Description: v.Description.Value,
-					Default:     v.Default.Value,
-					Options:     acStringToString(v.Options),
-					Type:        typeToString(v.Type),
-				})
+				wdi := WorkflowDispatchInput{
+					Name: keyword,
+
+					Options: acStringToString(v.Options),
+					Type:    typeToString(v.Type),
+				}
+				if v.Required != nil {
+					wdi.Required = v.Required.Value
+				}
+				if v.Description != nil {
+					wdi.Description = v.Description.Value
+				}
+				if v.Default != nil {
+					wdi.Default = v.Default.Value
+				}
+				inputs[i] = wdi
+				i++
 			}
 			event.inputs = inputs
 		case *actionlint.WebhookEvent:
+			event.acts = map[string][]string{}
 			if e.Branches != nil {
 				event.acts[e.Branches.Name.Value] = acStringToString(e.Branches.Values)
 			}
@@ -290,7 +303,6 @@ func GetEventsFromContent(content []byte) ([]*Event, error) {
 			if e.Types != nil {
 				event.acts["types"] = acStringToString(e.Types)
 			}
-			// if e.
 		}
 		events = append(events, event)
 	}