Fix sending empty notifications (#19589) (#19590)

Gusted · web-flow · commit 82f24bedc266 · 2022-05-02T21:28:12.000-05:00
- Backport #19589 - Don't send empty notifications on read notifications API.
diff --git a/routers/api/v1/notify/repo.go b/routers/api/v1/notify/repo.go
@@ -214,7 +214,7 @@ func ReadRepoNotifications(ctx *context.APIContext) {
 		targetStatus = models.NotificationStatusRead
 	}
 
-	changed := make([]*structs.NotificationThread, len(nl))
+	changed := make([]*structs.NotificationThread, 0, len(nl))
 
 	for _, n := range nl {
 		notif, err := models.SetNotificationStatus(n.ID, ctx.User, targetStatus)

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ func ReadRepoNotifications(ctx *context.APIContext) {`
`214`	`214`	`targetStatus = models.NotificationStatusRead`
`215`	`215`	`}`
`216`	`216`
`217`		`- changed := make([]*structs.NotificationThread, len(nl))`
	`217`	`+ changed := make([]*structs.NotificationThread, 0, len(nl))`
`218`	`218`
`219`	`219`	`for _, n := range nl {`
`220`	`220`	`notif, err := models.SetNotificationStatus(n.ID, ctx.User, targetStatus)`