Skip to content

Commit 87dfeb1

Browse files
committed
fix: prevent double markdown link brackets when pasting URL
When adding a link using the "Add a link" button in comment editor, pasting a URL resulted in incorrect Markdown formatting (double brackets) instead of replacing the placeholder text. This fix adds a context check to prevent creating a new markdown link when we're already inside an existing one. Fixes #34740
1 parent 24ce205 commit 87dfeb1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

web_src/js/features/comp/EditorUpload.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,10 @@ function handleClipboardText(textarea: HTMLTextAreaElement, e: ClipboardEvent, t
126126
const {value, selectionStart, selectionEnd} = textarea;
127127
const selectedText = value.substring(selectionStart, selectionEnd);
128128
const trimmedText = text.trim();
129-
if (selectedText && isUrl(trimmedText) && !isUrl(selectedText)) {
129+
const beforeSelection = value.substring(0, selectionStart);
130+
const afterSelection = value.substring(selectionEnd);
131+
const isInMarkdownLink = beforeSelection.endsWith('](') && afterSelection.startsWith(')');
132+
if (selectedText && isUrl(trimmedText) && !isUrl(selectedText) && !isInMarkdownLink) {
130133
e.preventDefault();
131134
replaceTextareaSelection(textarea, `[${selectedText}](${trimmedText})`);
132135
}

0 commit comments

Comments
 (0)