chore: move sorting to db execution with OrderBy

Author: imgurbot12

models/packages/package_file.go

@@ -68,7 +68,7 @@ func TryInsertFile(ctx context.Context, pf *PackageFile) (*PackageFile, error) {
 // GetFilesByVersionID gets all files of a version
 func GetFilesByVersionID(ctx context.Context, versionID int64) ([]*PackageFile, error) {
 	pfs := make([]*PackageFile, 0, 10)
-	return pfs, db.GetEngine(ctx).Where("version_id = ?", versionID).Find(&pfs)
+	return pfs, db.GetEngine(ctx).OrderBy("id").Where("version_id = ?", versionID).Find(&pfs)
 }
 
 // GetFileForVersionByID gets a file of a version by id

tests/integration/api_packages_generic_test.go

@@ -8,7 +8,6 @@ import (
 	"fmt"
 	"io"
 	"net/http"
-	"sort"
 	"testing"
 
 	"code.gitea.io/gitea/models/packages"
@@ -121,17 +120,12 @@ func TestPackageGeneric(t *testing.T) {
 		assert.Equal(t, packageVersion, resPkg.Version)
 		assert.Equal(t, int64(0), resPkg.DownloadCount)
 
-		// json results are ordered differently in different db engines for some reason
-		sort.Slice(resPkg.Files, func(i, j int) bool {
-			return resPkg.Files[i].Name < resPkg.Files[j].Name
-		})
-
 		resFile1 := resPkg.Files[0]
-		assert.Equal(t, "dummy.bin", resFile1.Name)
+		assert.Equal(t, filename, resFile1.Name)
 		assert.LessOrEqual(t, timestamp, resFile1.CreatedUnix)
 
 		resFile2 := resPkg.Files[1]
-		assert.Equal(t, filename, resFile2.Name)
+		assert.Equal(t, "dummy.bin", resFile2.Name)
 		assert.LessOrEqual(t, timestamp, resFile2.CreatedUnix)
 	})