Skip to content

Commit 8882022

Browse files
committed
fix
1 parent a68474a commit 8882022

File tree

3 files changed

+31
-2
lines changed

3 files changed

+31
-2
lines changed

modules/util/error_test.go

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
// Copyright 2025 The Gitea Authors. All rights reserved.
2+
// SPDX-License-Identifier: MIT
3+
4+
package util
5+
6+
import (
7+
"io"
8+
"testing"
9+
10+
"github.com/stretchr/testify/assert"
11+
)
12+
13+
func TestErrorTranslatable(t *testing.T) {
14+
var err error
15+
16+
err = ErrorWrapTranslatable(io.EOF, "key", 1)
17+
assert.ErrorIs(t, err, io.EOF)
18+
assert.Equal(t, "EOF", err.Error())
19+
assert.Equal(t, "key", err.(*errorTranslatableWrapper).trKey)
20+
assert.Equal(t, []any{1}, err.(*errorTranslatableWrapper).trArgs)
21+
22+
err = ErrorWrap(err, "new msg %d", 100)
23+
assert.ErrorIs(t, err, io.EOF)
24+
assert.Equal(t, "new msg 100", err.Error())
25+
26+
errTr := ErrorAsTranslatable(err)
27+
assert.Equal(t, "EOF", errTr.Error())
28+
assert.Equal(t, "key", errTr.(*errorTranslatableWrapper).trKey)
29+
}

routers/api/v1/repo/pull.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1041,8 +1041,8 @@ func MergePullRequest(ctx *context.APIContext) {
10411041
log.Trace("Pull request merged: %d", pr.ID)
10421042

10431043
if deleteBranchAfterMerge {
1044-
// no way to tell users that what error happens, and the PR has been merged, so ignore the error
10451044
if err = repo_service.DeleteBranchAfterMerge(ctx, ctx.Doer, pr.ID, nil); err != nil {
1045+
// no way to tell users that what error happens, and the PR has been merged, so ignore the error
10461046
log.Debug("DeleteBranchAfterMerge: pr %d, err: %v", pr.ID, err)
10471047
}
10481048
}

services/repository/branch.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -803,7 +803,7 @@ func DeleteBranchAfterMerge(ctx context.Context, doer *user_model.User, prID int
803803
}
804804
defer gitBaseCloser.Close()
805805

806-
gitHeadRepo, gitHeadCloser, err := gitrepo.RepositoryFromContextOrOpen(ctx, pr.BaseRepo)
806+
gitHeadRepo, gitHeadCloser, err := gitrepo.RepositoryFromContextOrOpen(ctx, pr.HeadRepo)
807807
if err != nil {
808808
return err
809809
}

0 commit comments

Comments
 (0)