close failed connections (#6898)

abhishek818 · abhishek818 · commit 88ca8fabea6c · 2024-07-24T15:21:27.000+05:30
Signed-off-by: abhishek818 &lt;abhishekguptaatweb17@gmail.com&gt;
diff --git a/services/auth/source/ldap/source_search.go b/services/auth/source/ldap/source_search.go
@@ -129,6 +129,7 @@ func dial(source *Source) (*ldap.Conn, error) {
 			conn, err := ldap.DialTLS("tcp", net.JoinHostPort(host, strconv.Itoa(source.Port)), tlsConfig)
 			if err != nil {
 				// Connection failed, try again with the next host.
+				conn.Close()
 				log.Trace("error during Dial for host %s: %w", host, err)
 				continue
 			}
@@ -139,6 +140,7 @@ func dial(source *Source) (*ldap.Conn, error) {
 
 		conn, err := ldap.Dial("tcp", net.JoinHostPort(host, strconv.Itoa(source.Port)))
 		if err != nil {
+			conn.Close()
 			log.Trace("error during Dial for host %s: %w", host, err)
 			continue
 		}

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,7 @@ func dial(source Source) (ldap.Conn, error) {`
`129`	`129`	`conn, err := ldap.DialTLS("tcp", net.JoinHostPort(host, strconv.Itoa(source.Port)), tlsConfig)`
`130`	`130`	`if err != nil {`
`131`	`131`	`// Connection failed, try again with the next host.`
	`132`	`+ conn.Close()`
`132`	`133`	`log.Trace("error during Dial for host %s: %w", host, err)`
`133`	`134`	`continue`
`134`	`135`	`}`
`@@ -139,6 +140,7 @@ func dial(source Source) (ldap.Conn, error) {`
`139`	`140`
`140`	`141`	`conn, err := ldap.Dial("tcp", net.JoinHostPort(host, strconv.Itoa(source.Port)))`
`141`	`142`	`if err != nil {`
	`143`	`+ conn.Close()`
`142`	`144`	`log.Trace("error during Dial for host %s: %w", host, err)`
`143`	`145`	`continue`
`144`	`146`	`}`