Treat 0 as a null value for exclusive order.

Author: telackey

modules/templates/util_render.go

@@ -144,7 +144,6 @@ func (ut *RenderUtils) RenderLabel(label *issues_model.Label) template.HTML {
 	// Scoped label
 	scopeHTML := ut.RenderEmoji(labelScope)
 	itemHTML := ut.RenderEmoji(label.Name[len(labelScope)+1:])
-	orderHTML := ut.RenderEmoji(strconv.Itoa(label.ExclusiveOrder))
 
 	// Make scope and item background colors slightly darker and lighter respectively.
 	// More contrast needed with higher luminance, empirically tweaked.
@@ -172,15 +171,29 @@ func (ut *RenderUtils) RenderLabel(label *issues_model.Label) template.HTML {
 	itemColor := "#" + hex.EncodeToString(itemBytes)
 	scopeColor := "#" + hex.EncodeToString(scopeBytes)
 
-	return htmlutil.HTMLFormat(`<span class="ui label %s scope-parent" data-tooltip-content title="%s">`+
-		`<div class="ui label scope-left" style="color: %s !important; background-color: %s !important">%s</div>`+
-		`<div class="ui label scope-middle" style="color: %s !important; background-color: %s !important">%s</div>`+
-		`<div class="ui label scope-right">%s</div>`+
-		`</span>`,
-		extraCSSClasses, descriptionText,
-		textColor, scopeColor, scopeHTML,
-		textColor, itemColor, itemHTML,
-		orderHTML)
+	if label.ExclusiveOrder > 0 {
+		// <scope> | <label> | <order>
+		orderHTML := ut.RenderEmoji(strconv.Itoa(label.ExclusiveOrder))
+		return htmlutil.HTMLFormat(`<span class="ui label %s scope-parent" data-tooltip-content title="%s">`+
+			`<div class="ui label scope-left" style="color: %s !important; background-color: %s !important">%s</div>`+
+			`<div class="ui label scope-middle" style="color: %s !important; background-color: %s !important">%s</div>`+
+			`<div class="ui label scope-right">%s</div>`+
+			`</span>`,
+			extraCSSClasses, descriptionText,
+			textColor, scopeColor, scopeHTML,
+			textColor, itemColor, itemHTML,
+			orderHTML)
+	} else {
+		// <scope> | <label>
+		return htmlutil.HTMLFormat(`<span class="ui label %s scope-parent" data-tooltip-content title="%s">`+
+			`<div class="ui label scope-left" style="color: %s !important; background-color: %s !important">%s</div>`+
+			`<div class="ui label scope-right" style="color: %s !important; background-color: %s !important">%s</div>`+
+			`</span>`,
+			extraCSSClasses, descriptionText,
+			textColor, scopeColor, scopeHTML,
+			textColor, itemColor, itemHTML,
+		)
+	}
 }
 
 // RenderEmoji renders html text with emoji post processors

options/label/Advanced.yaml

@@ -22,17 +22,17 @@ labels:
     description: Breaking change that won't be backward compatible
   - name: "Reviewed/Duplicate"
     exclusive: true
-    exclusive_order: 1
+    exclusive_order: 2
     color: 616161
     description: This issue or pull request already exists
   - name: "Reviewed/Invalid"
     exclusive: true
-    exclusive_order: 2
+    exclusive_order: 3
     color: 546e7a
     description: Invalid issue
   - name: "Reviewed/Confirmed"
     exclusive: true
-    exclusive_order: 0
+    exclusive_order: 1
     color: 795548
     description: Issue has been confirmed
   - name: "Reviewed/Won't Fix"
@@ -42,40 +42,40 @@ labels:
     description: This issue won't be fixed
   - name: "Status/Need More Info"
     exclusive: true
-    exclusive_order: 1
+    exclusive_order: 2
     color: 424242
     description: Feedback is required to reproduce issue or to continue work
   - name: "Status/Blocked"
     exclusive: true
-    exclusive_order: 0
+    exclusive_order: 1
     color: 880e4f
     description: Something is blocking this issue or pull request
   - name: "Status/Abandoned"
     exclusive: true
-    exclusive_order: 2
+    exclusive_order: 3
     color: "222222"
     description: Somebody has started to work on this but abandoned work
   - name: "Priority/Critical"
     exclusive: true
-    exclusive_order: 0
+    exclusive_order: 1
     color: b71c1c
     description: The priority is critical
     priority: critical
   - name: "Priority/High"
     exclusive: true
-    exclusive_order: 1
+    exclusive_order: 2
     color: d32f2f
     description: The priority is high
     priority: high
   - name: "Priority/Medium"
     exclusive: true
-    exclusive_order: 2
+    exclusive_order: 3
     color: e64a19
     description: The priority is medium
     priority: medium
   - name: "Priority/Low"
     exclusive: true
-    exclusive_order: 3
+    exclusive_order: 4
     color: 4caf50
     description: The priority is low
     priority: low

routers/web/repo/issue_list.go

@@ -483,7 +483,7 @@ func renderExclusiveLabelScopes(ctx *context.Context) {
 	scopeSet := make(map[string]bool, 0)
 	for _, label := range labels {
 		scope := label.ExclusiveScope()
-		if len(scope) > 0 {
+		if len(scope) > 0 && label.ExclusiveOrder > 0 {
 			scopeSet[scope] = true
 		}
 	}

web_src/js/features/comp/LabelEdit.ts

@@ -32,6 +32,12 @@ export function initCompLabelEdit(pageSelector: string) {
     toggleElem(elExclusiveWarning, showExclusiveWarning);
     if (!hasScope) elExclusiveInput.checked = false;
     toggleElem(elExclusiveOrderField, elExclusiveInput.checked);
+
+    if (parseInt(elExclusiveOrderInput.value) <= 0) {
+      elExclusiveOrderInput.style.color = "var(--color-placeholder-text) !important";
+    } else {
+      elExclusiveOrderInput.style.color = null;
+    }
   };
 
   const showLabelEditModal = (btn:HTMLElement) => {