Clean up npm dependencies (#35484)

- `type-fest` is replaced by our own types
- `@stylistic/eslint-plugin-js` is no longer in use, it was replaced
with `@stylistic/eslint-plugin`
- `@types/license-checker-webpack-plugin` does not apply to our forked
version and has a type stub

Author: silverwind

package.json

@@ -75,7 +75,6 @@
     "@types/dropzone": "5.7.9",
     "@types/jquery": "3.5.33",
     "@types/katex": "0.16.7",
-    "@types/license-checker-webpack-plugin": "0.2.5",
     "@types/pdfobject": "2.2.5",
     "@types/sortablejs": "1.15.8",
     "@types/swagger-ui-dist": "3.30.6",
@@ -111,7 +110,6 @@
     "stylelint-declaration-strict-value": "1.10.11",
     "stylelint-value-no-unknown-custom-properties": "6.0.1",
     "svgo": "4.0.0",
-    "type-fest": "4.41.0",
     "typescript-eslint": "8.43.0",
     "updates": "16.7.0",
     "vite-string-plugin": "1.4.6",

pnpm-lock.yaml

@@ -3,7 +3,6 @@ import type {Config} from 'updates';
 export default {
   exclude: [
     '@mcaptcha/vanilla-glue', // breaking changes in rc versions need to be handled
-    '@stylistic/eslint-plugin-js', // need to migrate to eslint 9
     'cropperjs', // need to migrate to v2 but v2 is not compatible with v1
     'tailwindcss', // need to migrate
   ],

updates.config.ts

@@ -27,7 +27,6 @@ import {chartJsColors} from '../utils/color.ts';
 import {sleep} from '../utils.ts';
 import 'chartjs-adapter-dayjs-4/dist/chartjs-adapter-dayjs-4.esm';
 import {fomanticQuery} from '../modules/fomantic/base.ts';
-import type {Entries} from 'type-fest';
 import {pathEscapeSegments} from '../utils/url.ts';
 
 const customEventListener: Plugin = {
@@ -57,6 +56,13 @@ Chart.register(
   customEventListener,
 );
 
+type ContributorsData = {
+  total: {
+    weeks: Record<string, any>,
+  },
+  [other: string]: Record<string, Record<string, any>>,
+}
+
 export default defineComponent({
   components: {ChartLine, SvgIcon},
   props: {
@@ -127,20 +133,20 @@ export default defineComponent({
           }
         } while (response.status === 202);
         if (response.ok) {
-          const data = await response.json();
-          const {total, ...rest} = data;
+          const data = await response.json() as ContributorsData;
+          const {total, ...other} = data;
           // below line might be deleted if we are sure go produces map always sorted by keys
           total.weeks = Object.fromEntries(Object.entries(total.weeks).sort());
 
-          const weekValues = Object.values(total.weeks) as any;
+          const weekValues = Object.values(total.weeks);
           this.xAxisStart = weekValues[0].week;
           this.xAxisEnd = firstStartDateAfterDate(new Date());
           const startDays = startDaysBetween(this.xAxisStart, this.xAxisEnd);
           total.weeks = fillEmptyStartDaysWithZeroes(startDays, total.weeks);
           this.xAxisMin = this.xAxisStart;
           this.xAxisMax = this.xAxisEnd;
           this.contributorsStats = {};
-          for (const [email, user] of Object.entries(rest) as Entries<Record<string, Record<string, any>>>) {
+          for (const [email, user] of Object.entries(other)) {
             user.weeks = fillEmptyStartDaysWithZeroes(startDays, user.weeks);
             this.contributorsStats[email] = user;
           }

web_src/js/components/RepoContributors.vue

@@ -1,5 +1,5 @@
 import {isDocumentFragmentOrElementNode} from '../utils/dom.ts';
-import type {Promisable} from 'type-fest';
+import type {Promisable} from '../types.ts';
 import type {InitPerformanceTracer} from './init.ts';
 
 let globalSelectorObserverInited = false;

web_src/js/modules/observer.ts

@@ -68,3 +68,5 @@ export type FomanticInitFunction = {
 };
 
 export type GitRefType = 'branch' | 'tag';
+
+export type Promisable<T> = T | Promise<T>; // stricter than type-fest which uses PromiseLike

web_src/js/types.ts

@@ -1,5 +1,5 @@
 import {debounce} from 'throttle-debounce';
-import type {Promisable} from 'type-fest';
+import type {Promisable} from '../types.ts';
 import type $ from 'jquery';
 import {isInFrontendUnitTest} from './testhelper.ts';