fix

Author: wxiaoguang

web_src/js/features/repo-issue-sidebar-combolist.ts

@@ -1,6 +1,7 @@
 import {fomanticQuery} from '../modules/fomantic/base.ts';
 import {POST} from '../modules/fetch.ts';
 import {queryElemChildren, queryElems, toggleElem} from '../utils/dom.ts';
+import {dropdownHideEmptyDividers} from '../modules/fomantic/dropdown.ts';
 
 // if there are draft comments, confirm before reloading, to avoid losing comments
 function issueSidebarReloadConfirmDraftComment() {
@@ -149,8 +150,10 @@ class IssueSidebarComboList {
     fomanticQuery(this.elDropdown).dropdown('setting', {
       action: 'nothing', // do not hide the menu if user presses Enter
       fullTextSearch: 'exact',
+      onShow: () => dropdownHideEmptyDividers(this.elDropdown),
+      onAfterFilterItems: () => dropdownHideEmptyDividers(this.elDropdown),
       onHide: () => this.onHide(),
-    });
+    }).dropdown('refresh');
   }
 }
 

web_src/js/modules/fomantic/dropdown.ts

@@ -1,6 +1,7 @@
 import $ from 'jquery';
 import {generateAriaId} from './base.ts';
 import type {FomanticInitFunction} from '../../types.ts';
+import {hideElem} from '../../utils/dom.ts';
 
 const ariaPatchKey = '_giteaAriaPatchDropdown';
 const fomanticDropdownFn = $.fn.dropdown;
@@ -59,6 +60,30 @@ function updateSelectionLabel(label: HTMLElement) {
   }
 }
 
+export function dropdownHideEmptyDividers(elDropdown: HTMLElement) {
+  const itemsContainer = elDropdown.querySelector('.scrolling.menu') ?? elDropdown.querySelector('.menu');
+  if (!itemsContainer) return;
+  let lastVisibleItemType: '' | 'divider' | 'item' = '';
+  let lastVisibleItem: Element;
+  for (const item of itemsContainer.children) {
+    if (!lastVisibleItemType && item.matches('.divider')) {
+      hideElem(item);
+      continue;
+    }
+    if (item.matches('.tw-hidden, .filtered')) continue;
+    // now, the item is visible
+    if (lastVisibleItemType === 'divider' && item.matches('.divider')) {
+      hideElem(item);
+      continue;
+    }
+    lastVisibleItemType = item.matches('.divider') ? 'divider' : 'item';
+    lastVisibleItem = item;
+  }
+  if (lastVisibleItemType === 'divider') {
+    hideElem(lastVisibleItem);
+  }
+}
+
 // delegate the dropdown's template functions and callback functions to add aria attributes.
 function delegateOne($dropdown: any) {
   const dropdownCall = fomanticDropdownFn.bind($dropdown);
@@ -72,6 +97,13 @@ function delegateOne($dropdown: any) {
   // * If the "dropdown icon" is clicked again when the menu is visible, Fomantic calls "blurSearch", so hide the menu
   dropdownCall('internal', 'blurSearch', function () { oldBlurSearch.call(this); dropdownCall('hide') });
 
+  const oldFilterItems = dropdownCall('internal', 'filterItems');
+  dropdownCall('internal', 'filterItems', function () {
+    oldFilterItems.call(this);
+    const onAfterFilterItems = dropdownCall('setting', 'onAfterFilterItems');
+    if (onAfterFilterItems) onAfterFilterItems();
+  });
+
   // the "template" functions are used for dynamic creation (eg: AJAX)
   const dropdownTemplates = {...dropdownCall('setting', 'templates'), t: performance.now()};
   const dropdownTemplatesMenuOld = dropdownTemplates.menu;