fix lint

Author: ChristopherHX

modules/actions/workflows.go

@@ -716,7 +716,7 @@ func matchWorkflowRunEvent(payload *api.WorkflowRunPayload, evt *jobparser.Event
 		case "types":
 			action := payload.Action
 			for _, val := range vals {
-				if glob.MustCompile(val, '/').Match(string(action)) {
+				if glob.MustCompile(val, '/').Match(action) {
 					matchTimes++
 					break
 				}

routers/api/v1/repo/action.go

@@ -1017,7 +1017,6 @@ func GetWorkflowRun(ctx *context.APIContext) {
 		return
 	}
 	ctx.JSON(http.StatusOK, convertedArtifact)
-	return
 }
 
 // GetWorkflowJobs Lists all jobs for a workflow run.
@@ -1130,7 +1129,6 @@ func GetWorkflowJob(ctx *context.APIContext) {
 		return
 	}
 	ctx.JSON(http.StatusOK, convertedWorkflowJob)
-	return
 }
 
 // GetArtifacts Lists all artifacts for a repository.

services/actions/notifier.go

@@ -10,7 +10,6 @@ import (
 	issues_model "code.gitea.io/gitea/models/issues"
 	"code.gitea.io/gitea/models/organization"
 	packages_model "code.gitea.io/gitea/models/packages"
-	"code.gitea.io/gitea/models/perm"
 	perm_model "code.gitea.io/gitea/models/perm"
 	access_model "code.gitea.io/gitea/models/perm/access"
 	repo_model "code.gitea.io/gitea/models/repo"
@@ -785,7 +784,10 @@ func (n *actionsNotifier) WorkflowRunStatusUpdate(ctx context.Context, repo *rep
 	defer gitRepo.Close()
 
 	convertedWorkflow, err := convert.GetActionWorkflow(ctx, gitRepo, repo, run.WorkflowID)
-
+	if err != nil {
+		log.Error("GetActionWorkflow: %v", err)
+		return
+	}
 	convertedRun, err := convert.ToActionWorkflowRun(ctx, repo, run)
 	if err != nil {
 		log.Error("ToActionWorkflowRun: %v", err)
@@ -797,7 +799,7 @@ func (n *actionsNotifier) WorkflowRunStatusUpdate(ctx context.Context, repo *rep
 		Workflow:     convertedWorkflow,
 		WorkflowRun:  convertedRun,
 		Organization: org,
-		Repo:         convert.ToRepo(ctx, repo, access_model.Permission{AccessMode: perm.AccessModeOwner}),
+		Repo:         convert.ToRepo(ctx, repo, access_model.Permission{AccessMode: perm_model.AccessModeOwner}),
 		Sender:       convert.ToUser(ctx, sender, nil),
 	}).Notify(ctx)
 }

services/convert/convert.go

@@ -235,7 +235,10 @@ func ToActionTask(ctx context.Context, t *actions_model.ActionTask) (*api.Action
 }
 
 func ToActionWorkflowRun(ctx context.Context, repo *repo_model.Repository, run *actions_model.ActionRun) (*api.ActionWorkflowRun, error) {
-	run.LoadRepo(ctx)
+	err := run.LoadRepo(ctx)
+	if err != nil {
+		return nil, err
+	}
 	status, conclusion := ToActionsStatus(run.Status)
 	return &api.ActionWorkflowRun{
 		ID:           run.ID,

services/webhook/notifier.go

@@ -995,6 +995,10 @@ func (*webhookNotifier) WorkflowRunStatusUpdate(ctx context.Context, repo *repo_
 	defer gitRepo.Close()
 
 	convertedWorkflow, err := convert.GetActionWorkflow(ctx, gitRepo, repo, run.WorkflowID)
+	if err != nil {
+		log.Error("GetActionWorkflow: %v", err)
+		return
+	}
 
 	convertedRun, err := convert.ToActionWorkflowRun(ctx, repo, run)
 	if err != nil {

templates/swagger/v1_json.tmpl

@@ -707,7 +707,7 @@ jobs:
 		assert.EqualValues(t, commitID, payloads[3].WorkflowJob.HeadSha)
 		assert.EqualValues(t, "repo1", payloads[3].Repo.Name)
 		assert.EqualValues(t, "user2/repo1", payloads[3].Repo.FullName)
-		assert.Contains(t, payloads[3].WorkflowJob.URL, fmt.Sprintf("/actions/runs/%d/jobs/%d", payloads[3].WorkflowJob.RunID, payloads[3].WorkflowJob.ID))
+		assert.Contains(t, payloads[3].WorkflowJob.URL, fmt.Sprintf("/actions/jobs/%d", payloads[3].WorkflowJob.ID))
 		assert.Contains(t, payloads[3].WorkflowJob.URL, payloads[3].WorkflowJob.RunURL)
 		assert.Contains(t, payloads[3].WorkflowJob.HTMLURL, fmt.Sprintf("/jobs/%d", 0))
 		assert.Len(t, payloads[3].WorkflowJob.Steps, 1)
@@ -745,7 +745,7 @@ jobs:
 		assert.EqualValues(t, commitID, payloads[6].WorkflowJob.HeadSha)
 		assert.EqualValues(t, "repo1", payloads[6].Repo.Name)
 		assert.EqualValues(t, "user2/repo1", payloads[6].Repo.FullName)
-		assert.Contains(t, payloads[6].WorkflowJob.URL, fmt.Sprintf("/actions/runs/%d/jobs/%d", payloads[6].WorkflowJob.RunID, payloads[6].WorkflowJob.ID))
+		assert.Contains(t, payloads[6].WorkflowJob.URL, fmt.Sprintf("/actions/jobs/%d", payloads[6].WorkflowJob.ID))
 		assert.Contains(t, payloads[6].WorkflowJob.URL, payloads[6].WorkflowJob.RunURL)
 		assert.Contains(t, payloads[6].WorkflowJob.HTMLURL, fmt.Sprintf("/jobs/%d", 1))
 		assert.Len(t, payloads[6].WorkflowJob.Steps, 2)