Fix IsUploadAvatarChanged comparison

raucao · raucao · commit 91cc45dbc48c · 2025-05-31T17:50:05.000+04:00
Use the correct function for hashing image data
diff --git a/models/user/avatar.go b/models/user/avatar.go
@@ -5,7 +5,6 @@ package user
 
 import (
 	"context"
-	"crypto/md5"
 	"fmt"
 	"image/png"
 	"io"
@@ -106,7 +105,7 @@ func (u *User) IsUploadAvatarChanged(data []byte) bool {
 	if !u.UseCustomAvatar || len(u.Avatar) == 0 {
 		return true
 	}
-	avatarID := fmt.Sprintf("%x", md5.Sum([]byte(fmt.Sprintf("%d-%x", u.ID, md5.Sum(data)))))
+	avatarID := avatar.HashAvatar(u.ID, data)
 	return u.Avatar != avatarID
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ package user`
`5`	`5`
`6`	`6`	`import (`
`7`	`7`	`"context"`
`8`		`- "crypto/md5"`
`9`	`8`	`"fmt"`
`10`	`9`	`"image/png"`
`11`	`10`	`"io"`
`@@ -106,7 +105,7 @@ func (u *User) IsUploadAvatarChanged(data []byte) bool {`
`106`	`105`	`if !u.UseCustomAvatar \|\| len(u.Avatar) == 0 {`
`107`	`106`	`return true`
`108`	`107`	`}`
`109`		`- avatarID := fmt.Sprintf("%x", md5.Sum([]byte(fmt.Sprintf("%d-%x", u.ID, md5.Sum(data)))))`
	`108`	`+ avatarID := avatar.HashAvatar(u.ID, data)`
`110`	`109`	`return u.Avatar != avatarID`
`111`	`110`	`}`
`112`	`111`