fix units

Author: wxiaoguang

modules/util/time_str.go

@@ -19,14 +19,19 @@ type timeStrGlobalVarsType struct {
 	re *regexp.Regexp
 }
 
+// When tracking working time, only hour/minute/second units are accurate and could be used.
+// For other units like "day", it depends on "how many working hours in a day: 6 or 7 or 8?
+// So at the moment, we only support hour/minute/second units.
+// In the future, it could be some configurable options to help users
+// to convert the working time to different units.
+
 var timeStrGlobalVars = sync.OnceValue[*timeStrGlobalVarsType](func() *timeStrGlobalVarsType {
 	v := &timeStrGlobalVarsType{}
 	v.re = regexp.MustCompile(`(?i)(\d+)\s*([dhms])`)
 	v.units = []struct {
 		name string
 		num  int64
 	}{
-		{"d", 60 * 60 * 24},
 		{"h", 60 * 60},
 		{"m", 60},
 		{"s", 1},

modules/util/time_str_test.go

@@ -17,11 +17,10 @@ func TestTimeStr(t *testing.T) {
 			output int64
 			err    bool
 		}{
-			{"1d", 86400, false},
 			{"1h", 3600, false},
 			{"1m", 60, false},
 			{"1s", 1, false},
-			{"1d 1h 1m 1s", 86400 + 3600 + 60 + 1, false},
+			{"1h 1m 1s", 3600 + 60 + 1, false},
 			{"1d1x", 0, true},
 		}
 		for _, test := range tests {
@@ -41,11 +40,10 @@ func TestTimeStr(t *testing.T) {
 			input  int64
 			output string
 		}{
-			{86400, "1d"},
 			{3600, "1h"},
 			{60, "1m"},
 			{1, "1s"},
-			{86400 + 60 + 1, "1d 1m 1s"},
+			{3600 + 1, "1h 1s"},
 		}
 		for _, test := range tests {
 			t.Run(test.output, func(t *testing.T) {

options/locale/locale_en-US.ini

@@ -1677,7 +1677,7 @@ issues.timetracker_timer_stop = Stop timer
 issues.timetracker_timer_discard = Discard timer
 issues.timetracker_timer_manually_add = Add Time
 
-issues.time_estimate_placeholder = 1d 2h 3m
+issues.time_estimate_placeholder = 1h 2m
 issues.time_estimate_set = Set estimated time
 issues.time_estimate_display = Estimate: %s
 issues.change_time_estimate_at = changed time estimate to <b>%s</b> %s