Support run-name evaluation in action runs

Author: badhezi

go.mod

@@ -317,7 +317,7 @@ replace github.com/hashicorp/go-version => github.com/6543/go-version v1.3.1
 
 replace github.com/shurcooL/vfsgen => github.com/lunny/vfsgen v0.0.0-20220105142115-2c99e1ffdfa0
 
-replace github.com/nektos/act => gitea.com/badhezi/act v0.0.1
+replace github.com/nektos/act => gitea.com/gitea/act v0.261.4
 
 // TODO: the only difference is in `PutObject`: the fork doesn't use `NewVerifyingReader(r, sha256.New(), oid, expectedSize)`, need to figure out why
 replace github.com/charmbracelet/git-lfs-transfer => gitea.com/gitea/git-lfs-transfer v0.2.0

go.sum

@@ -16,8 +16,8 @@ filippo.io/edwards25519 v1.1.0 h1:FNf4tywRC1HmFuKW5xopWpigGjJKiJSV0Cqo0cJWDaA=
 filippo.io/edwards25519 v1.1.0/go.mod h1:BxyFTGdWcka3PhytdK4V28tE5sGfRvvvRV7EaN4VDT4=
 git.sr.ht/~mariusor/go-xsd-duration v0.0.0-20220703122237-02e73435a078 h1:cliQ4HHsCo6xi2oWZYKWW4bly/Ory9FuTpFPRxj/mAg=
 git.sr.ht/~mariusor/go-xsd-duration v0.0.0-20220703122237-02e73435a078/go.mod h1:g/V2Hjas6Z1UHUp4yIx6bATpNzJ7DYtD0FG3+xARWxs=
-gitea.com/badhezi/act v0.0.1 h1:lsJL7/BHco3XJyFqI1GJKc0VTX0TPxg/tvsUwAcRiKU=
-gitea.com/badhezi/act v0.0.1/go.mod h1:Pg5C9kQY1CEA3QjthjhlrqOC/QOT5NyWNjOjRHw23Ok=
+gitea.com/gitea/act v0.261.4 h1:Tf9eLlvsYFtKcpuxlMvf9yT3g4Hshb2Beqw6C1STuH8=
+gitea.com/gitea/act v0.261.4/go.mod h1:Pg5C9kQY1CEA3QjthjhlrqOC/QOT5NyWNjOjRHw23Ok=
 gitea.com/gitea/git-lfs-transfer v0.2.0 h1:baHaNoBSRaeq/xKayEXwiDQtlIjps4Ac/Ll4KqLMB40=
 gitea.com/gitea/git-lfs-transfer v0.2.0/go.mod h1:UrXUCm3xLQkq15fu7qlXHUMlrhdlXHoi13KH2Dfiits=
 gitea.com/go-chi/binding v0.0.0-20240430071103-39a851e106ed h1:EZZBtilMLSZNWtHHcgq2mt6NSGhJSZBuduAlinMEmso=

services/actions/notifier_helper.go

@@ -30,6 +30,7 @@ import (
 	notify_service "code.gitea.io/gitea/services/notify"
 	"gopkg.in/yaml.v3"
 
+	"github.com/nektos/act/pkg/exprparser"
 	"github.com/nektos/act/pkg/jobparser"
 	"github.com/nektos/act/pkg/model"
 )
@@ -300,16 +301,14 @@ func handleWorkflows(
 	}
 
 	for _, dwf := range detectedWorkflows {
-		var yamlData map[string]any
-		if err := yaml.Unmarshal([]byte(dwf.Content), &yamlData); err != nil {
-			log.Fatal(err.Error())
-		}
 		run := &actions_model.ActionRun{
-			Title:             yamlData["run-name"].(string),
+			Title:             strings.SplitN(commit.CommitMessage, "\n", 2)[0],
 			RepoID:            input.Repo.ID,
+			Repo:              input.Repo,
 			OwnerID:           input.Repo.OwnerID,
 			WorkflowID:        dwf.EntryName,
 			TriggerUserID:     input.Doer.ID,
+			TriggerUser:       input.Doer,
 			Ref:               ref,
 			CommitSHA:         commit.ID.String(),
 			IsForkPullRequest: isForkPullRequest,
@@ -319,6 +318,11 @@ func handleWorkflows(
 			Status:            actions_model.StatusWaiting,
 		}
 
+		if err := EvaluateExpressionsForRun(run, dwf); err != nil {
+			log.Error("EvaluateExpressionsForRun: %v", err)
+			continue
+		}
+
 		need, err := ifNeedApproval(ctx, run, input.Repo, input.Doer)
 		if err != nil {
 			log.Error("check if need approval for repo %d with user %d: %v", input.Repo.ID, input.Doer.ID, err)
@@ -523,6 +527,11 @@ func handleSchedules(
 			Specs:         schedules,
 			Content:       dwf.Content,
 		}
+
+		if runName, err := parseRunNameFromDetectedWorkflow(dwf); err == nil {
+			run.Title = runName
+		}
+
 		crons = append(crons, run)
 	}
 
@@ -561,3 +570,56 @@ func DetectAndHandleSchedules(ctx context.Context, repo *repo_model.Repository)
 
 	return handleSchedules(ctx, scheduleWorkflows, commit, notifyInput, repo.DefaultBranch)
 }
+
+func newExpressionEvaluatorForRun(r *actions_model.ActionRun) (*jobparser.ExpressionEvaluator, error) {
+	ghCtx := &model.GithubContext{}
+	gitCtx := GenerateGiteaContext(r, nil)
+
+	gitCtxRaw, err := json.Marshal(gitCtx)
+	if err != nil {
+		log.Error("NewInterpolatorForRun: %v", err)
+		return nil, err
+	}
+
+	err = json.Unmarshal(gitCtxRaw, ghCtx)
+	if err != nil {
+		log.Error("NewInterpolatorForRun: %v", err)
+		return nil, err
+	}
+
+	interp := exprparser.NewInterpeter(&exprparser.EvaluationEnvironment{Github: ghCtx}, exprparser.Config{})
+	ee := jobparser.NewExpressionEvaluator(interp)
+	return ee, nil
+}
+
+func parseRunNameFromDetectedWorkflow(w *actions_module.DetectedWorkflow) (string, error) {
+	var data map[string]any
+	var value string
+
+	if err := yaml.Unmarshal([]byte(w.Content), &data); err != nil {
+		log.Error("parseRunNameFromDetectedWorkflow: %v", err)
+		return "", err
+	}
+
+	if v, ok := data["run-name"]; !ok {
+		return "", fmt.Errorf("run-name not found in workflow")
+	} else {
+		value = v.(string)
+	}
+
+	return value, nil
+}
+
+func EvaluateExpressionsForRun(r *actions_model.ActionRun, w *actions_module.DetectedWorkflow) error {
+	if runName, err := parseRunNameFromDetectedWorkflow(w); err == nil {
+		ee, err := newExpressionEvaluatorForRun(r)
+		if err != nil {
+			log.Error("newExpressionEvaluatorForRun: %v", err)
+			return err
+		}
+		r.Title = ee.Interpolate(runName)
+	} else {
+		log.Error("parseRunNameFromDetectedWorkflow: %v", err)
+	}
+	return nil
+}

services/actions/workflow.go

@@ -18,6 +18,7 @@ import (
 	"code.gitea.io/gitea/models/unit"
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/actions"
+	actions_module "code.gitea.io/gitea/modules/actions"
 	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/reqctx"
@@ -192,6 +193,8 @@ func DispatchActionWorkflow(ctx reqctx.RequestContext, doer *user_model.User, re
 
 	// find workflow from commit
 	var workflows []*jobparser.SingleWorkflow
+	dwf := &actions_module.DetectedWorkflow{}
+
 	for _, entry := range entries {
 		if entry.Name() != workflowID {
 			continue
@@ -201,10 +204,15 @@ func DispatchActionWorkflow(ctx reqctx.RequestContext, doer *user_model.User, re
 		if err != nil {
 			return err
 		}
+
 		workflows, err = jobparser.Parse(content)
 		if err != nil {
 			return err
 		}
+
+		dwf.Content = content
+		dwf.EntryName = entry.Name()
+
 		break
 	}
 
@@ -244,9 +252,11 @@ func DispatchActionWorkflow(ctx reqctx.RequestContext, doer *user_model.User, re
 	run := &actions_model.ActionRun{
 		Title:             strings.SplitN(runTargetCommit.CommitMessage, "\n", 2)[0],
 		RepoID:            repo.ID,
+		Repo:              repo,
 		OwnerID:           repo.OwnerID,
 		WorkflowID:        workflowID,
 		TriggerUserID:     doer.ID,
+		TriggerUser:       doer,
 		Ref:               string(refName),
 		CommitSHA:         runTargetCommit.ID.String(),
 		IsForkPullRequest: false,
@@ -256,6 +266,10 @@ func DispatchActionWorkflow(ctx reqctx.RequestContext, doer *user_model.User, re
 		Status:            actions_model.StatusWaiting,
 	}
 
+	if err := EvaluateExpressionsForRun(run, dwf); err != nil {
+		log.Error("EvaluateExpressionsForRun: %v", err)
+	}
+
 	// cancel running jobs of the same workflow
 	if err := CancelPreviousJobs(
 		ctx,

web_src/js/components/RepoActionView.vue

@@ -346,11 +346,11 @@ export default defineComponent({
         const isFirstLoad = !this.run.status;
         const job = await this.fetchJobData(abortController);
         if (this.loadingAbortController !== abortController) return;
-
+        console.log(job)
         this.artifacts = job.artifacts || [];
         this.run = job.state.run;
         this.currentJob = job.state.currentJob;
-
+        console.log(this.currentJob)
         // sync the currentJobStepsStates to store the job step states
         for (let i = 0; i < this.currentJob.steps.length; i++) {
           const expanded = isFirstLoad && this.optionAlwaysExpandRunning && this.currentJob.steps[i].status === 'running';